From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: shmobile: armadillo: Fix coherent DMA mask
Date: Tue, 24 Dec 2013 12:10:33 +0000 [thread overview]
Message-ID: <3830440.B057Ir2lkO@avalon> (raw)
In-Reply-To: <1387217769-22751-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
Hi Simon,
On Thursday 19 December 2013 15:31:20 Simon Horman wrote:
> On Mon, Dec 16, 2013 at 03:53:57PM -0800, Kuninori Morimoto wrote:
> > Hi
> >
> > > Commit 4dcfa60071b3d23f0181f27d8519f12e37cefbb9 ("ARM: DMA-API: better
> > > handing of DMA masks for coherent allocations") added an additional
> > > check to the coherent DMA mask that results in an error when the mask is
> > > larger than what dma_addr_t can address.
> > >
> > > Set the LCDC coherent DMA mask to DMA_BIT_MASK(32) instead of ~0 to fix
> > > the problem.
> > >
> > > Signed-off-by: Laurent Pinchart
> > > <laurent.pinchart+renesas@ideasonboard.com>
> > > ---
> >
> > For all patches
> >
> > Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Thanks, I have queued these up as fixes for v3.13.
Thank you. Could you please tell me in which branch I can find them ?
> For my own reference: The commit referenced above appeared in v3.12-rc2.
>
> > > arch/arm/mach-shmobile/board-armadillo800eva.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c
> > > b/arch/arm/mach-shmobile/board-armadillo800eva.c index
> > > d9e28c7a..82d027c 100644
> > > --- a/arch/arm/mach-shmobile/board-armadillo800eva.c
> > > +++ b/arch/arm/mach-shmobile/board-armadillo800eva.c
> > > @@ -483,7 +483,7 @@ static struct platform_device lcdc0_device = {
> > > .id = 0,
> > > .dev = {
> > > .platform_data = &lcdc0_info,
> > > - .coherent_dma_mask = ~0,
> > > + .coherent_dma_mask = DMA_BIT_MASK(32),
> > > },
> > > };
> > >
> > > @@ -580,7 +580,7 @@ static struct platform_device hdmi_lcdc_device = {
> > > .id = 1,
> > > .dev = {
> > > .platform_data = &hdmi_lcdc_info,
> > > - .coherent_dma_mask = ~0,
> > > + .coherent_dma_mask = DMA_BIT_MASK(32),
> > > },
> > > };
> > >
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-12-24 12:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 18:16 [PATCH 1/3] ARM: shmobile: armadillo: Fix coherent DMA mask Laurent Pinchart
2013-12-16 23:53 ` Kuninori Morimoto
2013-12-19 6:31 ` Simon Horman
2013-12-24 12:10 ` Laurent Pinchart [this message]
2013-12-24 14:26 ` Simon Horman
2013-12-26 5:36 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2013-12-30 0:57 [GIT PULL 0/3] Third Round of Renesas ARM based SoC Fixes for v3.13 Simon Horman
2013-12-30 0:58 ` [PATCH 1/3] ARM: shmobile: armadillo: Fix coherent DMA mask Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3830440.B057Ir2lkO@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox