Re: [PATCH 2/2] ARM: shmobile: r8a7794: alt: Enable ethernet controller

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Sergei,

Thank you for the review.

On Wednesday 04 February 2015 00:43:25 Sergei Shtylyov wrote:
> On 01/27/2015 11:45 AM, Laurent Pinchart wrote:
> > Enable the ethernet controller for the Alt board. Pin muxing entries are
> > currently left out as r8a7794 pin control support isn't available yet.
> > We thus rely on the boot loader to configure ethernet pins for now.
> > 
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >   arch/arm/boot/dts/r8a7794-alt.dts | 13 +++++++++++++
> >   1 file changed, 13 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/r8a7794-alt.dts
> > b/arch/arm/boot/dts/r8a7794-alt.dts index 0d848e605071..25bf434433b1
> > 100644
> > --- a/arch/arm/boot/dts/r8a7794-alt.dts
> > +++ b/arch/arm/boot/dts/r8a7794-alt.dts
> > @@ -43,6 +43,19 @@
> > 
> >   	status = "okay";
> >   
> >   };
> > 
> > +&ether {
> > +	phy-handle = <&phy1>;
> > +	renesas,ether-link-active-low;
> > +	status = "okay";
> > +
> > +	phy1: ethernet-phy@1 {
> > +		reg = <1>;
> > +		interrupt-parent = <&irqc0>;
> > +		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> 
> The hardware manual tells me the PHY uses IRQ8#, not IRQ0#.

I don't have the complete Alt schematics. I've double-checked the block 
diagram and it mentions "GP1_24(IRQ)" next to the PHY. This patch is thus 
incorrect, but where did you find a mention of IRQ8 ?

-- 
Regards,

Laurent Pinchart