From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH/RFC] ARM: shmobile: LPAE memory bank CMA assignment prototype
Date: Mon, 28 Dec 2015 10:24:31 +0000 [thread overview]
Message-ID: <3987591.uIcGfaluy4@avalon> (raw)
In-Reply-To: <20151219014005.6274.87661.sendpatchset@little-apple>
Hi Geert,
On Monday 28 December 2015 11:21:08 Geert Uytterhoeven wrote:
> On Mon, Dec 28, 2015 at 11:10 AM, Laurent Pinchart wrote:
> >> Regarding this patch, it is just a proof of concept to test allocation
> >> from a high memory address without modifying any hardware description.
> >>
> >> > I don't want to see board code coming back through the back door.
> >> > What's wrong with just reserving memory in DT with the reserved-memory
> >> > bindings and assigning it to the DU ?
> >>
> >> Describing device-to-memory bank assignment in DT equals mixing
> >> software policy with hardware description. I prefer to keep the
> >> software policy in C and the hardware description in DT.
> >>
> >> If you think there are better ways to reserve memory, why don't you
> >> cook up a counter proposal and post it in a public space? =)
> >
> > Doing it in DT is the better way in my opinion :-) There are established
> > DT bindings for that purpose, and that's what upstream is using.
>
> I'm a bit sceptical about describing this in DT, too, as this is a software
> policy, not a hardware description, but it's indeed described in
> Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt
The idea of a DT-like kernel configuration file has been toyed with in the
past but as far as I know it got abandoned. It was certainly an interesting
idea, and could possibly have led to a better solution, but today what we have
is DT. Board files are not the way to go to implement such a feature.
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2015-12-28 10:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-19 1:40 [PATCH/RFC] ARM: shmobile: LPAE memory bank CMA assignment prototype Magnus Damm
2015-12-27 8:51 ` Laurent Pinchart
2015-12-28 3:17 ` Magnus Damm
2015-12-28 10:10 ` Laurent Pinchart
2015-12-28 10:21 ` Geert Uytterhoeven
2015-12-28 10:24 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3987591.uIcGfaluy4@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).