From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] pinctrl: sh-pfc: r8a7779: Fix missing MOD_SEL2 entry
Date: Fri, 31 May 2013 01:37:15 +0000 [thread overview]
Message-ID: <4019907.Zkj1PmlV3E@avalon> (raw)
In-Reply-To: <1369906266-30205-1-git-send-email-phil.edworthy@renesas.com>
Hi Phil,
Thank you for the patch.
On Thursday 30 May 2013 10:31:06 Phil Edworthy wrote:
> The list of functions selected by the MOD_SEL2 register was missing
> an entry. This caused all entries after this to modify the MOD_SEL2
> register incorrectly.
>
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/pinctrl/sh-pfc/pfc-r8a7779.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c index 13feaa0..5dfeb3e 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> @@ -2525,7 +2525,7 @@ static struct pinmux_cfg_reg pinmux_config_regs[] = {
> /* SEL_SCIF [2] */
> FN_SEL_SCIF_0, FN_SEL_SCIF_1, FN_SEL_SCIF_2, FN_SEL_SCIF_3,
> /* SEL_CANCLK [2] */
> - FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2,
> + FN_SEL_CANCLK_0, FN_SEL_CANCLK_1, FN_SEL_CANCLK_2, 0,
> /* SEL_CAN0 [1] */
> FN_SEL_CAN0_0, FN_SEL_CAN0_1,
> /* SEL_HSCIF1 [1] */
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-05-31 1:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 9:31 [PATCH] pinctrl: sh-pfc: r8a7779: Fix missing MOD_SEL2 entry Phil Edworthy
2013-05-31 1:37 ` Laurent Pinchart [this message]
2013-05-31 2:43 ` Simon Horman
2013-05-31 3:03 ` Laurent Pinchart
2013-05-31 5:42 ` Simon Horman
2013-05-31 8:26 ` phil.edworthy
2013-05-31 23:40 ` Simon Horman
2013-06-03 7:46 ` phil.edworthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4019907.Zkj1PmlV3E@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox