From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Date: Tue, 09 Sep 2014 15:20:11 +0000 Subject: Re: [GIT PULL] Third Round of Renesas ARM Based SoC Soc Updates for v3.18 Message-Id: <4196537.hvL3OIMxQq@wuerfel> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Tuesday 09 September 2014 13:22:17 Simon Horman wrote: > Hi Olof, Hi Kevin, Hi Arnd, > > Please consider these third round of Renesas ARM based SoC soc updates for v3.18. > > This pull request is based on the previous round of > such requests, tagged as renesas-soc2-for-v3.18, > which you have already pulled. > > This pull-request has a minor conflict with > "[GIT PULL] Renesas ARM Based SoC Kconfig Cleanups for v3.18", > tagged as renesas-kconfig-cleanups-for-v3.18, which you > have previously pulled. Pulled into next/soc as well. One detail I noticed for the first time is that the setup-*.c file hides the machine descriptor inside of #ifdef CONFIG_USE_OF, which makes no sense since the file is only compiled when ARCH_MULTIPLATFORM is set, and that does 'select USE_OF'. It would be better not to add that #ifdef for new files, and you could perhaps remove the existing ones after the conversion to multiplatform is complete. Thanks, Arnd