Re: [PATCH v3 5/6] dma: rcar-dma: warn if transfer cannot start as TE = 1

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Muhammad,

Thank you for the patch.

On Tuesday 29 September 2015 22:44:47 hamzahfrq.sub@gmail.com wrote:
> From: Muhammad Hamza Farooq <mfarooq@visteon.com>
> 
> Signed-off-by: Muhammad Hamza Farooq <mfarooq@visteon.com>
> ---
>  drivers/dma/sh/rcar-dmac.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
> index 0b5a367..6eec878 100644
> --- a/drivers/dma/sh/rcar-dmac.c
> +++ b/drivers/dma/sh/rcar-dmac.c
> @@ -327,7 +327,8 @@ static void rcar_dmac_chan_start_xfer(struct
> rcar_dmac_chan *chan) struct rcar_dmac_desc *desc = chan->desc.running;
>  	u32 chcr = desc->chcr;
> 
> -	WARN_ON_ONCE(rcar_dmac_chan_is_busy(chan));
> +	WARN_ON_ONCE(rcar_dmac_chan_is_busy(chan) ||
> +			rcar_dmac_last_tx_complete(chan));

Why is that a problem ?

>  	if (chan->mid_rid >= 0)
>  		rcar_dmac_chan_write(chan, RCAR_DMARS, chan->mid_rid);

-- 
Regards,

Laurent Pinchart