From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Mon, 21 Jan 2013 12:23:10 +0000 Subject: Re: [PATCH 5/8] ARM: shmobile: add a GPIO controller DT node for sh7372 Message-Id: <4209290.uCBdrcvT3q@avalon> List-Id: References: <1358356097-26180-1-git-send-email-g.liakhovetski@gmx.de> <1358356097-26180-6-git-send-email-g.liakhovetski@gmx.de> In-Reply-To: <1358356097-26180-6-git-send-email-g.liakhovetski@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hi Guennadi, Thanks for the patch. On Wednesday 16 January 2013 18:08:14 Guennadi Liakhovetski wrote: > Add a missing GPIO controller node to sh7372. > > Signed-off-by: Guennadi Liakhovetski > --- > arch/arm/boot/dts/sh7372.dtsi | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/sh7372.dtsi b/arch/arm/boot/dts/sh7372.dtsi > index 582fdec..7ca9322 100644 > --- a/arch/arm/boot/dts/sh7372.dtsi > +++ b/arch/arm/boot/dts/sh7372.dtsi > @@ -19,6 +19,14 @@ > }; > }; > > + gpio: pfc@e6050000 { > + compatible = "renesas,pfc-sh7372"; > + reg = <0xe6050000 0x8000>, > + <0xe605800c 0x20>; Shouldn't the second one be <0xe605800c 0x1c>; > + gpio-controller; > + #gpio-cells = <2>; > + }; > + I haven't checked the board files, have you made sure that the PFC device won't be instantiated twice, once from DT and once from board code ? > soc { > compatible = "simple-bus"; > #address-cells = <1>; -- Regards, Laurent Pinchart