From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 03/04] ARM: shmobile: Genmai I2C-over-GPIO support
Date: Thu, 28 Nov 2013 17:14:38 +0000 [thread overview]
Message-ID: <4401360.Outsal0mcb@avalon> (raw)
In-Reply-To: <52977954.20006@cogentembedded.com>
On Thursday 28 November 2013 21:11:48 Sergei Shtylyov wrote:
> On 27-11-2013 15:04, Wolfram Sang wrote:
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> +
> >> + eeprom: 24c128@50 {
> >> + compatible = "at,24c128";
> >
> > Minor nit: Should be a vendor name, not the name of the driver
>
> Moreover, the node should be named generically, like "flash@50", not
> "24c128@50".
Or, given that it's an eeprom, "eeprom@50" ? :-)
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-11-28 17:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 8:27 [PATCH 00/04] ARM: shmobile: r7s72100 and Genmai GPIO / PINCTRL support Magnus Damm
2013-11-27 8:27 ` [PATCH 01/04] ARM: shmobile: r7s72100 GPIO and PINCTRL device nodes Magnus Damm
2013-11-27 8:27 ` [PATCH 02/04] ARM: shmobile: Genmai LED1 and LED2 support Magnus Damm
2013-11-27 11:16 ` Laurent Pinchart
2013-11-27 8:28 ` [PATCH 03/04] ARM: shmobile: Genmai I2C-over-GPIO support Magnus Damm
2013-11-27 11:04 ` Wolfram Sang
2013-11-28 17:11 ` Sergei Shtylyov
2013-11-28 17:14 ` Laurent Pinchart [this message]
2013-11-28 18:13 ` Sergei Shtylyov
2013-11-27 11:15 ` Laurent Pinchart
2013-11-28 0:44 ` Magnus Damm
2013-11-28 0:46 ` Laurent Pinchart
2013-11-27 8:28 ` [PATCH 04/04] ARM: shmobile: Genmai SCIF2 PINCTRL configuration Magnus Damm
2013-11-27 11:16 ` Laurent Pinchart
2013-11-27 11:13 ` [PATCH 00/04] ARM: shmobile: r7s72100 and Genmai GPIO / PINCTRL support Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4401360.Outsal0mcb@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).