Re: [PATCH] clk: shmobile: Fix SMTP clock index

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Valentine,

Thank you for the patch.

On Friday 27 December 2013 18:42:09 Valentine Barshak wrote:
> Use clkidx when registering SMTP clocks instead of loop counter
> since the value is then used to access the specific clock index bit
> in the smtp register.
> 
> The issue was introduced by the following commit:
> f94859c215b6d977 "clk: shmobile: Add MSTP clock support"

I wonder how I've failed to notice this :-/

> Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Mike, could you please pick this up for v3.14 ?

> ---
>  drivers/clk/shmobile/clk-mstp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/shmobile/clk-mstp.c
> b/drivers/clk/shmobile/clk-mstp.c index e576b60..be7d017 100644
> --- a/drivers/clk/shmobile/clk-mstp.c
> +++ b/drivers/clk/shmobile/clk-mstp.c
> @@ -205,8 +205,8 @@ static void __init cpg_mstp_clocks_init(struct
> device_node *np) continue;
>  		}
> 
> -		clks[clkidx] = cpg_mstp_clock_register(name, parent_name, i,
> -						       group);
> +		clks[clkidx] = cpg_mstp_clock_register(name, parent_name,
> +						       clkidx, group);
>  		if (!IS_ERR(clks[clkidx])) {
>  			group->data.clk_num = max(group->data.clk_num, clkidx);
>  			/*
-- 
Regards,

Laurent Pinchart