* [PATCH v2] pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu_remove()
@ 2013-05-20 13:45 Axel Lin
2013-05-20 13:46 ` Laurent Pinchart
0 siblings, 1 reply; 9+ messages in thread
From: Axel Lin @ 2013-05-20 13:45 UTC (permalink / raw)
To: Thierry Reding; +Cc: Laurent Pinchart, Simon Horman, linux-kernel, linux-sh
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pwm/pwm-renesas-tpu.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c
index 8e6d8d7..319a6fe 100644
--- a/drivers/pwm/pwm-renesas-tpu.c
+++ b/drivers/pwm/pwm-renesas-tpu.c
@@ -432,6 +432,11 @@ static int tpu_remove(struct platform_device *pdev)
{
struct tpu_device *tpu = platform_get_drvdata(pdev);
unsigned int i;
+ int ret;
+
+ ret = pwmchip_remove(&tpu->chip);
+ if (ret)
+ return ret;
for (i = 0; i < ARRAY_SIZE(tpu->pwms); ++i) {
struct tpu_pwm_device *pwm = &tpu->pwms[i];
--
1.8.1.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2] pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu_remove()
2013-05-20 13:45 [PATCH v2] pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu_remove() Axel Lin
@ 2013-05-20 13:46 ` Laurent Pinchart
2013-05-23 1:39 ` Simon Horman
0 siblings, 1 reply; 9+ messages in thread
From: Laurent Pinchart @ 2013-05-20 13:46 UTC (permalink / raw)
To: Axel Lin, Simon Horman; +Cc: Thierry Reding, linux-kernel, linux-sh
Hi Axel,
Thank you for the patch.
On Monday 20 May 2013 21:45:41 Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/pwm/pwm-renesas-tpu.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c
> index 8e6d8d7..319a6fe 100644
> --- a/drivers/pwm/pwm-renesas-tpu.c
> +++ b/drivers/pwm/pwm-renesas-tpu.c
> @@ -432,6 +432,11 @@ static int tpu_remove(struct platform_device *pdev)
> {
> struct tpu_device *tpu = platform_get_drvdata(pdev);
> unsigned int i;
> + int ret;
> +
> + ret = pwmchip_remove(&tpu->chip);
> + if (ret)
> + return ret;
>
> for (i = 0; i < ARRAY_SIZE(tpu->pwms); ++i) {
> struct tpu_pwm_device *pwm = &tpu->pwms[i];
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2] pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu_remove()
2013-05-20 13:46 ` Laurent Pinchart
@ 2013-05-23 1:39 ` Simon Horman
2013-05-23 19:12 ` Thierry Reding
0 siblings, 1 reply; 9+ messages in thread
From: Simon Horman @ 2013-05-23 1:39 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Axel Lin, Thierry Reding, linux-kernel, linux-sh
On Mon, May 20, 2013 at 03:46:59PM +0200, Laurent Pinchart wrote:
> Hi Axel,
>
> Thank you for the patch.
>
> On Monday 20 May 2013 21:45:41 Axel Lin wrote:
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks. I have queued this up for v3.11 in the pinmux branch
of my renesas tree on kernel.org.
>
> > ---
> > drivers/pwm/pwm-renesas-tpu.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c
> > index 8e6d8d7..319a6fe 100644
> > --- a/drivers/pwm/pwm-renesas-tpu.c
> > +++ b/drivers/pwm/pwm-renesas-tpu.c
> > @@ -432,6 +432,11 @@ static int tpu_remove(struct platform_device *pdev)
> > {
> > struct tpu_device *tpu = platform_get_drvdata(pdev);
> > unsigned int i;
> > + int ret;
> > +
> > + ret = pwmchip_remove(&tpu->chip);
> > + if (ret)
> > + return ret;
> >
> > for (i = 0; i < ARRAY_SIZE(tpu->pwms); ++i) {
> > struct tpu_pwm_device *pwm = &tpu->pwms[i];
> --
> Regards,
>
> Laurent Pinchart
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2] pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu_remove()
2013-05-23 1:39 ` Simon Horman
@ 2013-05-23 19:12 ` Thierry Reding
2013-05-25 5:33 ` Simon Horman
2013-05-25 13:42 ` Laurent Pinchart
0 siblings, 2 replies; 9+ messages in thread
From: Thierry Reding @ 2013-05-23 19:12 UTC (permalink / raw)
To: Simon Horman; +Cc: Laurent Pinchart, Axel Lin, linux-kernel, linux-sh
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
On Thu, May 23, 2013 at 10:39:34AM +0900, Simon Horman wrote:
> On Mon, May 20, 2013 at 03:46:59PM +0200, Laurent Pinchart wrote:
> > Hi Axel,
> >
> > Thank you for the patch.
> >
> > On Monday 20 May 2013 21:45:41 Axel Lin wrote:
> > > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> >
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Thanks. I have queued this up for v3.11 in the pinmux branch
> of my renesas tree on kernel.org.
I'd rather take this through the PWM tree along with the original driver
patch.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu_remove()
2013-05-23 19:12 ` Thierry Reding
@ 2013-05-25 5:33 ` Simon Horman
2013-05-25 13:42 ` Laurent Pinchart
1 sibling, 0 replies; 9+ messages in thread
From: Simon Horman @ 2013-05-25 5:33 UTC (permalink / raw)
To: Thierry Reding; +Cc: Laurent Pinchart, Axel Lin, linux-kernel, linux-sh
On Thu, May 23, 2013 at 09:12:17PM +0200, Thierry Reding wrote:
> On Thu, May 23, 2013 at 10:39:34AM +0900, Simon Horman wrote:
> > On Mon, May 20, 2013 at 03:46:59PM +0200, Laurent Pinchart wrote:
> > > Hi Axel,
> > >
> > > Thank you for the patch.
> > >
> > > On Monday 20 May 2013 21:45:41 Axel Lin wrote:
> > > > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > >
> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > Thanks. I have queued this up for v3.11 in the pinmux branch
> > of my renesas tree on kernel.org.
>
> I'd rather take this through the PWM tree along with the original driver
> patch.
Sure that is fine.
I had them queued up in my tree but I have dropped them now.
That should propogate to linux-next in the not too distant future.
I have also dropped the following changes from my tree
as they appear to ether depend on the TPU PWD driver or one
of the other patches in the list below.
Laurent, I think it would be best if you resubmitted these patches
once there is a stable branch available with the TPU PWD driver merged
which I can use as a base.
ARM: mach-shmobile: armadillo800eva: Add backlight support
ARM: mach-shmobile: kota2: Use leds-pwm + pwm-rmob
leds: Remove leds-renesas-tpu driver
sh-pfc: sh73a0: Remove function GPIOs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu_remove()
2013-05-23 19:12 ` Thierry Reding
2013-05-25 5:33 ` Simon Horman
@ 2013-05-25 13:42 ` Laurent Pinchart
2013-05-25 15:20 ` Axel Lin
2013-05-26 9:18 ` Thierry Reding
1 sibling, 2 replies; 9+ messages in thread
From: Laurent Pinchart @ 2013-05-25 13:42 UTC (permalink / raw)
To: Thierry Reding; +Cc: Simon Horman, Axel Lin, linux-kernel, linux-sh
Hi Thierry,
On Thursday 23 May 2013 21:12:17 Thierry Reding wrote:
> On Thu, May 23, 2013 at 10:39:34AM +0900, Simon Horman wrote:
> > On Mon, May 20, 2013 at 03:46:59PM +0200, Laurent Pinchart wrote:
> > > Hi Axel,
> > >
> > > Thank you for the patch.
> > >
> > > On Monday 20 May 2013 21:45:41 Axel Lin wrote:
> > > > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > >
> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > Thanks. I have queued this up for v3.11 in the pinmux branch
> > of my renesas tree on kernel.org.
>
> I'd rather take this through the PWM tree along with the original driver
> patch.
As I will need to submit a new version of the renesas-tpu patches should I
fold this patch in ?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu_remove()
2013-05-25 13:42 ` Laurent Pinchart
@ 2013-05-25 15:20 ` Axel Lin
2013-05-26 9:18 ` Thierry Reding
1 sibling, 0 replies; 9+ messages in thread
From: Axel Lin @ 2013-05-25 15:20 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Thierry Reding, Simon Horman, linux-kernel@vger.kernel.org,
linux-sh
2013/5/25 Laurent Pinchart <laurent.pinchart@ideasonboard.com>:
> Hi Thierry,
>
> On Thursday 23 May 2013 21:12:17 Thierry Reding wrote:
>> On Thu, May 23, 2013 at 10:39:34AM +0900, Simon Horman wrote:
>> > On Mon, May 20, 2013 at 03:46:59PM +0200, Laurent Pinchart wrote:
>> > > Hi Axel,
>> > >
>> > > Thank you for the patch.
>> > >
>> > > On Monday 20 May 2013 21:45:41 Axel Lin wrote:
>> > > > Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> > >
>> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> >
>> > Thanks. I have queued this up for v3.11 in the pinmux branch
>> > of my renesas tree on kernel.org.
>>
>> I'd rather take this through the PWM tree along with the original driver
>> patch.
>
> As I will need to submit a new version of the renesas-tpu patches should I
> fold this patch in ?
Hi Laurent,
I think you can fold this patch in if you are going to submit a new version
of the renesas-tpu patches.
Regards,
Axel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu_remove()
2013-05-25 13:42 ` Laurent Pinchart
2013-05-25 15:20 ` Axel Lin
@ 2013-05-26 9:18 ` Thierry Reding
2013-05-29 14:39 ` Laurent Pinchart
1 sibling, 1 reply; 9+ messages in thread
From: Thierry Reding @ 2013-05-26 9:18 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Simon Horman, Axel Lin, linux-kernel, linux-sh
[-- Attachment #1: Type: text/plain, Size: 948 bytes --]
On Sat, May 25, 2013 at 03:42:42PM +0200, Laurent Pinchart wrote:
> Hi Thierry,
>
> On Thursday 23 May 2013 21:12:17 Thierry Reding wrote:
> > On Thu, May 23, 2013 at 10:39:34AM +0900, Simon Horman wrote:
> > > On Mon, May 20, 2013 at 03:46:59PM +0200, Laurent Pinchart wrote:
> > > > Hi Axel,
> > > >
> > > > Thank you for the patch.
> > > >
> > > > On Monday 20 May 2013 21:45:41 Axel Lin wrote:
> > > > > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > > >
> > > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >
> > > Thanks. I have queued this up for v3.11 in the pinmux branch
> > > of my renesas tree on kernel.org.
> >
> > I'd rather take this through the PWM tree along with the original driver
> > patch.
>
> As I will need to submit a new version of the renesas-tpu patches should I
> fold this patch in ?
Yes, that's fine with me. It'd be nice to credit Axel, though.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu_remove()
2013-05-26 9:18 ` Thierry Reding
@ 2013-05-29 14:39 ` Laurent Pinchart
0 siblings, 0 replies; 9+ messages in thread
From: Laurent Pinchart @ 2013-05-29 14:39 UTC (permalink / raw)
To: Thierry Reding; +Cc: Simon Horman, Axel Lin, linux-kernel, linux-sh
[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]
Hi Thierry,
On Sunday 26 May 2013 11:18:24 Thierry Reding wrote:
> On Sat, May 25, 2013 at 03:42:42PM +0200, Laurent Pinchart wrote:
> > On Thursday 23 May 2013 21:12:17 Thierry Reding wrote:
> > > On Thu, May 23, 2013 at 10:39:34AM +0900, Simon Horman wrote:
> > > > On Mon, May 20, 2013 at 03:46:59PM +0200, Laurent Pinchart wrote:
> > > > > On Monday 20 May 2013 21:45:41 Axel Lin wrote:
> > > > > > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > > > >
> > > > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > >
> > > > Thanks. I have queued this up for v3.11 in the pinmux branch
> > > > of my renesas tree on kernel.org.
> > >
> > > I'd rather take this through the PWM tree along with the original driver
> > > patch.
> >
> > As I will need to submit a new version of the renesas-tpu patches should I
> > fold this patch in ?
>
> Yes, that's fine with me. It'd be nice to credit Axel, though.
Sure. I'll add Axel's SoB line to the patch.
--
Regards,
Laurent Pinchart
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-05-29 14:39 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-20 13:45 [PATCH v2] pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu_remove() Axel Lin
2013-05-20 13:46 ` Laurent Pinchart
2013-05-23 1:39 ` Simon Horman
2013-05-23 19:12 ` Thierry Reding
2013-05-25 5:33 ` Simon Horman
2013-05-25 13:42 ` Laurent Pinchart
2013-05-25 15:20 ` Axel Lin
2013-05-26 9:18 ` Thierry Reding
2013-05-29 14:39 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).