Re: [PATCH 2/3] renesas: change to using clock-indices

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Geert,

On Saturday 15 February 2014 14:20:16 Geert Uytterhoeven wrote:
> Hi Laurent, Magnus,
> 
> On Fri, Feb 14, 2014 at 3:34 PM, Laurent Pinchart wrote:
> >> >> Regarding how to roll it into the SoC code, I feel that this patch
> >> >> [2/3] and next patch [3/3] potentially causes breakage with the
> >> >> existing binding that was part of the v3.13 upstream kernel.
> >> > 
> >> > If I'm not mistaken that's v3.14, not v3.13.
> >> 
> >> Nope, it's merged in v3.13. Looked it up before sending the email. =)
> > 
> > I might be missing something, but
> > 
> > $ git log v3.13 --oneline -- drivers/clk/shmobile/ | wc
> >       0       0       0
> > 
> > $ git log v3.14-rc1 --oneline -- drivers/clk/shmobile/ | wc
> >       6      48     309
> 
> It's the published bindings that count, right?

I suppose both count, but they've been mainlined at the same time anyway.

> Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt
> was added in commit f94859c215b6d977794108a1a9a101239e393c09
> ("clk: shmobile: Add MSTP clock support").
> 
> $ git tag --contains f94859c215b6d977794108a1a9a101239e393c09
> v3.14-rc1
> v3.14-rc2
> $
> 
> Now, the bindings must be in flux, as the documentation doesn't match
> the code, nor the example:
> 
> Documentation says:
> 
> +  - renesas,indices: Indices of the gate clocks into the group (0 to 31)
> 
> Example and implementation use "renesas,clock-indices":
> 
>                 renesas,clock-indices = <
>                         R8A7790_CLK_TPU0 R8A7790_CLK_MMCIF1
> R8A7790_CLK_SDHI3 R8A7790_CLK_SDHI2 R8A7790_CLK_SDHI1 R8A7790_CLK_SDHI0
> R8A7790_CLK_MMCIF0
> 
>                 >;
> 
> Woops...

You don't need to convince me that the DT bindings need time to stabilize :-)

I'll fix this after hearing from Mike on Ben's patches.

-- 
Regards,

Laurent Pinchart