From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 1/2] pinctrl: sh-pfc: fix r8a7790 Function Select register tables
Date: Wed, 15 May 2013 11:00:42 +0000 [thread overview]
Message-ID: <4690431.MKYUU7odFj@avalon> (raw)
In-Reply-To: <Pine.LNX.4.64.1305151238040.10596@axis700.grange>
On Wednesday 15 May 2013 12:46:49 Guennadi Liakhovetski wrote:
> Fix several errors in Peripheral Function Select register tables for
> r8a7790, which prevent various function pins from being correctly
> configured.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> v2: fix a fixed bit-count, thanks to Laurent for catching
>
> drivers/pinctrl/sh-pfc/pfc-r8a7790.c | 14 ++++++--------
> 1 files changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7790.c
> b/drivers/pinctrl/sh-pfc/pfc-r8a7790.c index 5be2999..a2f83ae 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7790.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7790.c
> @@ -3175,7 +3175,7 @@ static struct pinmux_cfg_reg pinmux_config_regs[] = {
> FN_SIM0_D_B, 0, 0, 0, 0, 0, 0, 0, }
> },
> { PINMUX_CFG_REG_VAR("IPSR11", 0xE606004C, 32,
> - 2, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3) {
> + 2, 3, 3, 2, 4, 3, 2, 2, 2, 2, 2, 1, 4) {
> /* IP11_31_30 [2] */
> FN_SSI_SCK0129, FN_CAN_CLK_B, FN_MOUT0, 0,
> /* IP11_29_27 [3] */
> @@ -3441,12 +3441,10 @@ static struct pinmux_cfg_reg pinmux_config_regs[] > { FN_SEL_SOF0_0, FN_SEL_SOF0_1, }
> },
> { PINMUX_CFG_REG_VAR("MOD_SEL2", 0xE6060094, 32,
> - 2, 1, 1, 1, 1, 2, 1, 2, 1,
> - 2, 1, 1, 1, 3, 3, 2, 3, 2, 2) {
> - /* RESEVED [2] */
> + 3, 1, 1, 1, 2, 1, 2, 1, 2,
> + 1, 1, 1, 3, 3, 2, 3, 2, 2) {
> + /* RESEVED [3] */
> 0, 0, 0, 0, 0, 0, 0, 0,
> - /* RESEVED [1] */
> - 0, 0,
> /* SEL_TMU1 [1] */
> FN_SEL_TMU1_0, FN_SEL_TMU1_1,
> /* SEL_HSCIF1 [1] */
> @@ -3462,8 +3460,8 @@ static struct pinmux_cfg_reg pinmux_config_regs[] = {
> /* SEL_CAN1 [1] */
> FN_SEL_CAN1_0, FN_SEL_CAN1_1,
> /* RESEVED [2] */
> - 0, 0, 0, 0, 0, 0, 0, 0,
> - /* RESEVED [1] */
> + 0, 0, 0, 0,
> + /* RESEVED [1] (actually TX2, RX2 vs. TX2_B, RX2_B of SCIF2) */
> 0, 0,
> /* SEL_ADI [1] */
> FN_SEL_ADI_0, FN_SEL_ADI_1,
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-05-15 11:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 10:46 [PATCH v2 1/2] pinctrl: sh-pfc: fix r8a7790 Function Select register tables Guennadi Liakhovetski
2013-05-15 11:00 ` Laurent Pinchart [this message]
2013-05-20 7:36 ` Linus Walleij
2013-05-20 11:15 ` Laurent Pinchart
2013-05-23 1:39 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4690431.MKYUU7odFj@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).