From: Stuart MENEFY <stuart.menefy@st.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: fix readsl/writesl argument
Date: Wed, 20 Feb 2008 12:15:52 +0000 [thread overview]
Message-ID: <47BC19F8.4030007@st.com> (raw)
In-Reply-To: <20080220102853.22714.57848.sendpatchset@clockwork.opensource.se>
Magnus
Magnus Damm wrote:
> writesl() and readsl() use void __iomem * as argument but the current sh
> version of __raw_writesl()/__rawreadsl() takes unsigned long. Casting the
> pointer fixes smc91x warnings.
...
> --- 0001/include/asm-sh/io.h
> +++ work/include/asm-sh/io.h 2008-02-20 16:34:28.000000000 +0900
> -#define writesl __raw_writesl
> -#define readsl __raw_readsl
> +#define writesl(m, a, c) __raw_writesl((unsigned long)(m), (a), (c))
> +#define readsl(m, a, c) __raw_readsl((unsigned long)(m), (a), (c))
Wouldn't it be better to do this as inline functions, that way we don't
loose the type checking?
Stuart
next prev parent reply other threads:[~2008-02-20 12:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 10:28 [PATCH] sh: fix readsl/writesl argument Magnus Damm
2008-02-20 12:15 ` Stuart MENEFY [this message]
2008-02-21 2:57 ` Magnus Damm
2008-02-26 5:23 ` Paul Mundt
2008-02-26 6:39 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BC19F8.4030007@st.com \
--to=stuart.menefy@st.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox