From: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
To: video4linux-list@redhat.com
Cc: linux-sh@vger.kernel.org
Subject: Re: [PATCH 01/06] soc_camera: Move spinlocks
Date: Mon, 14 Jul 2008 12:36:58 +0000 [thread overview]
Message-ID: <487B486A.7040403@teltonika.lt> (raw)
In-Reply-To: <Pine.LNX.4.64.0807141427140.11348@axis700.grange>
Guennadi Liakhovetski wrote:
> On Mon, 14 Jul 2008, Magnus Damm wrote:
>
>> This patch moves the spinlock handling from soc_camera.c to the actual
>> camera host driver. The spinlock alloc/free callbacks are replaced with
>> code in init_videobuf().
>
> As merits of this move were not quite obvious to me (you lose the
> possibility to use default lock allocation / freeing in soc_camera.c), I
> extended your comment as follows:
>
> This patch moves the spinlock handling from soc_camera.c to the actual
> camera host driver. The spinlock_alloc/free callbacks are replaced with
> code in init_videobuf(). So far all camera host drivers implement their
> own spinlock_alloc/free methods anyway, and videobuf_queue_core_init()
> BUGs on a NULL spinlock argument, so, new camera host drivers will not
> forget to provide a spinlock when initialising their videobug queues.
videobuf
^
next prev parent reply other threads:[~2008-07-14 12:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-14 12:02 [PATCH 00/06] soc_camera: SuperH Mobile CEU patches V3 Magnus Damm
2008-07-14 12:02 ` [PATCH 01/06] soc_camera: Move spinlocks Magnus Damm
2008-07-14 12:31 ` Guennadi Liakhovetski
2008-07-14 12:36 ` Paulius Zaleckas [this message]
2008-07-14 12:43 ` Guennadi Liakhovetski
2008-07-15 8:23 ` Magnus Damm
2008-07-14 12:02 ` [PATCH 02/06] soc_camera: Add 16-bit bus width support Magnus Damm
2008-07-14 12:02 ` [PATCH 03/06] videobuf: Fix gather spelling Magnus Damm
2008-07-14 12:02 ` [PATCH 04/06] videobuf: Add physically contiguous queue code V3 Magnus Damm
2008-07-14 12:20 ` [PATCH 04/06] videobuf: Add physically contiguous queue code Paulius Zaleckas
2008-07-14 12:02 ` [PATCH 05/06] sh_mobile_ceu_camera: Add SuperH Mobile CEU driver V3 Magnus Damm
2008-07-18 7:39 ` [PATCH 05/06] sh_mobile_ceu_camera: Add SuperH Mobile CEU driver Guennadi Liakhovetski
2008-07-18 8:07 ` [PATCH 05/06] sh_mobile_ceu_camera: Add SuperH Mobile CEU driver V3 Magnus Damm
2008-07-18 8:23 ` [PATCH 05/06] sh_mobile_ceu_camera: Add SuperH Mobile CEU driver Guennadi Liakhovetski
2008-07-18 21:05 ` [PATCH 05/06] sh_mobile_ceu_camera: Add SuperH Mobile CEU driver V3 Paul Mundt
2008-07-18 21:46 ` Paul Mundt
2008-07-18 22:14 ` [PATCH 05/06] sh_mobile_ceu_camera: Add SuperH Mobile CEU driver Guennadi Liakhovetski
2008-07-18 22:27 ` [PATCH 05/06] sh_mobile_ceu_camera: Add SuperH Mobile CEU driver V3 Paul Mundt
2008-07-18 22:48 ` [PATCH 05/06] sh_mobile_ceu_camera: Add SuperH Mobile CEU driver Guennadi Liakhovetski
2008-07-14 12:02 ` [PATCH 06/06] soc_camera_platform: Add SoC Camera Platform driver Magnus Damm
2008-07-18 7:40 ` [PATCH 00/06] soc_camera: SuperH Mobile CEU patches V3 Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487B486A.7040403@teltonika.lt \
--to=paulius.zaleckas@teltonika.lt \
--cc=linux-sh@vger.kernel.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox