* [PATCH] sh_eth: unsigned ndev->irq cannot be negative
@ 2008-09-10 17:22 roel kluin
2008-09-11 5:59 ` Paul Mundt
0 siblings, 1 reply; 2+ messages in thread
From: roel kluin @ 2008-09-10 17:22 UTC (permalink / raw)
To: linux-sh
unsigned ndev->irq cannot be negative
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c
index 6a06b95..c52cc82 100644
--- a/drivers/net/sh_eth.c
+++ b/drivers/net/sh_eth.c
@@ -1182,11 +1182,12 @@ static int sh_eth_drv_probe(struct platform_device *pdev)
devno = 0;
ndev->dma = -1;
- ndev->irq = platform_get_irq(pdev, 0);
- if (ndev->irq < 0) {
+ ret = platform_get_irq(pdev, 0);
+ if (ret < 0) {
ret = -ENODEV;
goto out_release;
}
+ ndev->irq = ret;
SET_NETDEV_DEV(ndev, &pdev->dev);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sh_eth: unsigned ndev->irq cannot be negative
2008-09-10 17:22 [PATCH] sh_eth: unsigned ndev->irq cannot be negative roel kluin
@ 2008-09-11 5:59 ` Paul Mundt
0 siblings, 0 replies; 2+ messages in thread
From: Paul Mundt @ 2008-09-11 5:59 UTC (permalink / raw)
To: linux-sh
On Wed, Sep 10, 2008 at 07:22:44PM +0200, roel kluin wrote:
> unsigned ndev->irq cannot be negative
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
On Wed, Sep 10, 2008 at 07:34:44PM +0200, roel kluin wrote:
> possibly since commit b420b1a7a17ea88531d0e12b2f2679a0c8365803
> ---
> rtc-sh: Unsigned rtc->{periodic,carry,alarm}_irq cannot be negative
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-11 5:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-10 17:22 [PATCH] sh_eth: unsigned ndev->irq cannot be negative roel kluin
2008-09-11 5:59 ` Paul Mundt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox