linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: add support FLCTL for ap325rxa board
Date: Wed, 22 Oct 2008 09:45:14 +0000	[thread overview]
Message-ID: <48FEF62A.4090603@renesas.com> (raw)
In-Reply-To: <48C63126.5060008@renesas.com>

Paul Mundt wrote:
> On Tue, Sep 09, 2008 at 05:17:42PM +0900, Yoshihiro Shimoda wrote:
>> This patch adds platform_device for sh_flctl driver, NAND Flash
>> simple partition, and GPIO setting.
>>
>> Signed-off-by: Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>
> 
> Now that the sh_flctl MTD driver has been merged, I have applied this
> patch.

Thank you very much.

>>  static struct i2c_board_info __initdata ap325rxa_i2c_devices[] = {
>> @@ -312,6 +354,16 @@ static void __init ap325rxa_setup(char **cmdline_p)
>>  	ctrl_outw(ctrl_inw(PORT_PSELD) & ~0x0003, PORT_PSELD);
>>  	ctrl_outw((ctrl_inw(PORT_PZCR) & ~0xff00) | 0x5500, PORT_PZCR);
>>  	ctrl_outb((ctrl_inb(PORT_PZDR) & ~0xf0) | 0x20, PORT_PZDR);
>> +
>> +	/* FLCTL */
>> +	ctrl_outw(0, PORT_PUCR);
>> +	ctrl_outw(0, PORT_PVCR);
>> +	ctrl_outw(0, PORT_PSELC);
>> +	ctrl_outw(0, PORT_HIZCRC);
>> +	ctrl_outw(0xFFFF, PORT_DRVCRA);
>> +	ctrl_outw(0xFFFF, PORT_DRVCRB);
>> +	ctrl_outw((ctrl_inw(PORT_PXCR) & 0x3fff) | 0x4000, PORT_PXCR);
>> +	ctrl_outb(0x80, PORT_PXDR);
>>  }
>>
>>  static struct sh_machine_vector mv_ap325rxa __initmv = {
> 
> I checked this part in with your original patch, but have since rewrote
> it to grab all of the FLCTL pins through the new pinmux code. Please make
> sure that it still works for you.

I checked that FLCTL worked correctly using today's sh-2.6.git.

Thanks,
Yoshihiro Shimoda

  parent reply	other threads:[~2008-10-22  9:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-09  8:17 [PATCH] sh: add support FLCTL for ap325rxa board Yoshihiro Shimoda
2008-10-21  9:11 ` Paul Mundt
2008-10-22  9:45 ` Yoshihiro Shimoda [this message]
2008-10-22 10:03 ` Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48FEF62A.4090603@renesas.com \
    --to=shimoda.yoshihiro@renesas.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).