From: Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/3] sh: Add support 32-bit physical addressing by other
Date: Mon, 23 Feb 2009 05:10:42 +0000 [thread overview]
Message-ID: <49A22FD2.5020303@renesas.com> (raw)
In-Reply-To: <499E867C.6080202@renesas.com>
Jean-Christophe PLAGNIOL-VILLARD wrote:
<- snip ->
> On 19:31 Fri 20 Feb , Yoshihiro Shimoda wrote:
>> diff --git a/arch/sh/boot/Makefile b/arch/sh/boot/Makefile
>> index c16ccd4..d7ff2af 100644
>> --- a/arch/sh/boot/Makefile
>> +++ b/arch/sh/boot/Makefile
>> @@ -34,8 +34,10 @@ $(obj)/compressed/vmlinux: FORCE
>> $(Q)$(MAKE) $(build)=$(obj)/compressed $@
>>
> is it not possible to create a var or a macro to avoid all this if esle
> and idef else?
Thank you very much for your comment. I modified it as follows. I think that
it improved that before.
******************************************
KERNEL_MEMORY := 0x00000000
ifeq ($(CONFIG_FIXED_PMB),y)
KERNEL_MEMORY := $(shell /bin/bash -c 'printf "0x%08x" \
$$[$(CONFIG_MEMORY_START) & 0x1fffffff]')
endif
ifeq ($(CONFIG_29BIT),y)
KERNEL_MEMORY := $(shell /bin/bash -c 'printf "0x%08x" \
$$[$(CONFIG_MEMORY_START)]')
endif
KERNEL_LOAD := $(shell /bin/bash -c 'printf "0x%08x" \
$$[$(CONFIG_PAGE_OFFSET) + \
$(KERNEL_MEMORY) + \
$(CONFIG_ZERO_PAGE_OFFSET)]')
KERNEL_ENTRY := $(shell /bin/bash -c 'printf "0x%08x" \
$$[$(CONFIG_PAGE_OFFSET) + \
$(KERNEL_MEMORY) + \
$(CONFIG_ZERO_PAGE_OFFSET) + $(CONFIG_ENTRY_OFFSET)]')
******************************************
<- snip ->
>> index 7b4b82b..69fe954 100644
>> --- a/arch/sh/kernel/vmlinux_32.lds.S
>> +++ b/arch/sh/kernel/vmlinux_32.lds.S
>> @@ -15,8 +15,11 @@ OUTPUT_ARCH(sh)
>> ENTRY(_start)
>> SECTIONS
>> {
>> -#ifdef CONFIG_32BIT
>> - . = CONFIG_PAGE_OFFSET + CONFIG_ZERO_PAGE_OFFSET;
>> +#ifdef CONFIG_FIXED_PMB
>> + . = CONFIG_PAGE_OFFSET + (CONFIG_MEMORY_START & 0x1fffffff) +
>> + CONFIG_ZERO_PAGE_OFFSET;
>> +#elif defined(CONFIG_32BIT)
>> + . = CONFIG_PAGE_OFFSET + CONFIG_MEMORY_START + CONFIG_ZERO_PAGE_OFFSET;
> sure? 32Bit and 29bit are the same
Thank you! I have made a mistake. I will fix it as follows.
******************************************
#elif defined(CONFIG_32BIT)
. = CONFIG_PAGE_OFFSET + CONFIG_ZERO_PAGE_OFFSET;
#else
. = CONFIG_PAGE_OFFSET + CONFIG_MEMORY_START + CONFIG_ZERO_PAGE_OFFSET;
#endif
******************************************
Best Regards,
Yoshihiro Shimoda
prev parent reply other threads:[~2009-02-23 5:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-20 10:31 [PATCH 1/3] sh: Add support 32-bit physical addressing by other method Yoshihiro Shimoda
2009-02-20 12:19 ` [PATCH 1/3] sh: Add support 32-bit physical addressing by Jean-Christophe PLAGNIOL-VILLARD
2009-02-23 5:10 ` Yoshihiro Shimoda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A22FD2.5020303@renesas.com \
--to=shimoda.yoshihiro@renesas.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox