public inbox for linux-sh@vger.kernel.org
 help / color / mirror / Atom feed
From: Francesco VIRLINZI <francesco.virlinzi@st.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH][RFC] sh: suspend interpreter V1
Date: Mon, 30 Mar 2009 07:02:54 +0000	[thread overview]
Message-ID: <49D06E9E.4000506@st.com> (raw)
In-Reply-To: <20090323091739.25647.6773.sendpatchset@rx1.opensource.se>

Hi Magnus, Yoshii-san
> Francesco, can you convince yoshii-san why we should add support for
> an interpreter? =)
>   
I can try ;-)
Than: I would push the interpreter solution because it will allow us to 
be free in the future.
If all the issue on 'cache preload' 'interpreter-instruction' are 
resolved in 'one-shot' right now
 in the future for each new SOC we will have only to resolve 'what it 
has to be done' and not 'how'....
This simplifies our development flow because we don't have to rediscover 
the wheel with always the same
 issue.
I know the interpreter will not allow 'optimized code' but I think the 
suspend assembly code doesn't have
 to be fast, it has to be right and for this reason I think it has to be 
written one time for ever...
Moreover an assembly code SOC oriented can not be seen as 'general 
purpose' solution while the interpreter
 can be 'theoretically' used by everybody.
>   
>> But, I don't think we need even backward jump.
>> What we want is conditional wait and delay, isn't it?
>>
>> SH_PM_OP_WAIT_UNTIL_EQ(addr, value) while(read(addr)!=value)/*wait*/;
>> SH_PM_OP_WAIT_UNTIL_SET(addr, mask) while(!(read(addr)&mask))/*wait*/;
>> SH_PM_OP_WAIT_UNTIL_CLR(addr, mask) while(read(addr)&mask)/*wait*/;
>> SH_PM_OP_DELAY_LOOP(count) while(count--)/*wait*/;
>>     
>
> I wonder if we can make those opcodes fit with the current format?
> Maybe no. They look fine with me though, but I'm not sure about
> Francescos use case.
>   
Enough good also for me but with a little change just one is enough:

SH_PM_OP_WAIT_UNTIL_EQ(addr, mask, value) while((read(addr) & mask) != value); /*wait*/;

In this manner it doesn't matter what each bit does (in the same word 
some bits could be set and some other could be reset).
Regards
 Francesco

  parent reply	other threads:[~2009-03-30  7:02 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-23  9:17 [PATCH][RFC] sh: suspend interpreter V1 Magnus Damm
2009-03-23 15:35 ` Francesco VIRLINZI
2009-03-24  7:00 ` Francesco VIRLINZI
2009-03-24 11:08 ` Magnus Damm
2009-03-24 13:41 ` Francesco VIRLINZI
2009-03-25 10:10 ` Magnus Damm
2009-03-25 14:46 ` takasi-y
2009-03-30  2:45 ` Magnus Damm
2009-03-30  7:02 ` Francesco VIRLINZI [this message]
2009-03-31  8:42 ` Paul Mundt
2009-04-15 11:15 ` Magnus Damm
2009-04-15 11:23 ` Paul Mundt
2009-04-16 14:15 ` Francesco VIRLINZI
2009-04-16 14:22 ` Francesco VIRLINZI
2009-04-17  2:07 ` Magnus Damm
2009-04-17  6:44 ` Francesco VIRLINZI
2009-04-17 10:39 ` Magnus Damm
2009-04-17 12:00 ` Francesco VIRLINZI
2009-04-17 21:38 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-20 10:26 ` Magnus Damm
2009-04-20 12:27 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-20 12:33 ` Francesco VIRLINZI
2009-04-20 12:55 ` Francesco VIRLINZI
2009-04-20 13:03 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-20 13:15 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-20 13:30 ` Michael Trimarchi
2009-04-21  7:17 ` Francesco VIRLINZI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D06E9E.4000506@st.com \
    --to=francesco.virlinzi@st.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox