Re: [PATCH v3] dmaengine: sh: Add Support SuperH DMA Engine driver

[Nobuhiro Iwamatsu <iwamatsu.nobuhiro@renesas.com>]

Hi, Dan.

Thank you for your commnets.

Dan Williams wrote:
> Paul Mundt wrote:
>> On Wed, Mar 25, 2009 at 03:55:20PM +0900, Nobuhiro Iwamatsu wrote:
>>> This supported all DMA channels, and it was tested in SH7722,
>>> SH7780 and SH7763.
>>> This can not use with SH DMA API.
>>>
>>> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu.nobuhiro@renesas.com>
>>> Reviewed-by: Matt Fleming <matt@console-pimps.org>
>>
>> I don't know why you dropped Dan from the CC, but you need his Acked-by
>> or Reviewed-by before this can be merged.
> 
> Thanks Paul.
> 
> This version still has the problem of up leveling the descriptor lock to 
>  spin_lock_irqsave from spin_lock_bh.  This poses a problem for 
> completion callback support where callbacks assume that interrupts are 
> enabled, like a timer callback.  I have also spotted a new problem below:
> 

I understood. I fix your undication part.

Best regards,
  Nobuhiro