From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yoshihiro Shimoda Date: Thu, 09 Apr 2009 11:08:21 +0000 Subject: Re: [PATCH] sh7786: modify usb setup timeout judgment bug. Message-Id: <49DDD725.4010706@renesas.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org Dear Michael, Michael Trimarchi wrote: > Hi, > > Yoshihiro Shimoda wrote: >> Hi Morimoto-san, >> >> morimoto.kuninori@renesas.com wrote: >>> Dear Michael >>> >>>>>> shimoda san >>>>> Can you change use driver to be able to call peculiar init function ? >>>>> Or Can I do that ? >>>>> >>>> I will try to provide a patch if you want on 14 of April, or if you >>>> prefer just start and >>>> send a patch to the reviewer :) >>> Ooops. sorry. >>> My request is to "shimoda san" who created usb driver for SH :) >>> >> I think that it is after next month if I try it. >> Because linux-2.6.30 merge window was just closed recently :) >> > I don't have all the data. Look at the code there only the init function > to be > deferrable. Introduce a platform data it can be usefull but I would like to > know if there are other info that can be passed with the platform data. Thank you for your comment! I understood it. > Is that the only cpu that needs a specific initialization? Before a patch > maybe we can ask how can we use it? > Just to know: > what is this function sh7786_usb_use_exclock? SH7763's OHCI need initialization too (but differ proccess: arch/sh/board/mach-sh7763rdp/setup.c: line 172). I'm sorry, I don't know detail of this function. Morimoto-san, please tell me this information? > for example the s3c2410 define and use a platform data, for port flags or > power control or overun current situation. What can we put in a platform > data? The Renesas usb host controllers are: - OHCI (drivers/usb/host/ohci-sh.c) - r8a66597 (drivers/usb/host/r8a66597-hcd.c) In OHCI, we can put extend initialize function in a platform data only at the moment. However, in r8a66597, we can put all module_param data. Thanks, Yoshihiro Shimoda