public inbox for linux-sh@vger.kernel.org
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh7786: modify usb setup timeout judgment bug.
Date: Fri, 10 Apr 2009 01:24:32 +0000	[thread overview]
Message-ID: <49DE9FD0.8080208@renesas.com> (raw)
In-Reply-To: <uzleql7ud.wl%morimoto.kuninori@renesas.com>

Hi Paul,

Paul Mundt wrote:
> On Thu, Apr 09, 2009 at 08:08:21PM +0900, Yoshihiro Shimoda wrote:
>> Michael Trimarchi wrote:
>>> Is that the only cpu that needs a specific initialization? Before a patch
>>> maybe we can ask how can we use it?
>>> Just to know:
>>> what is this function sh7786_usb_use_exclock?
>> SH7763's OHCI need initialization too
>> (but differ proccess: arch/sh/board/mach-sh7763rdp/setup.c: line 172).
>>
>> I'm sorry, I don't know detail of this function.
>> Morimoto-san, please tell me this information?
>>
>>> for example the s3c2410 define and use a platform data, for port flags or
>>> power control or overun current situation. What can we put in a platform 
>>> data?
>> The Renesas usb host controllers are:
>>  - OHCI (drivers/usb/host/ohci-sh.c)
>>  - r8a66597 (drivers/usb/host/r8a66597-hcd.c)
>>
>> In OHCI, we can put extend initialize function in a platform data only at the moment.
>> However, in r8a66597, we can put all module_param data.
>>
> I don't see any reason why we can't accomodate the r7a66597 platform data
> change within -rc2, so if that is the way you want to fix this, then that
> should be fine. Of course if it is too invasive, we will just use the
> original fix in the board, but there is not much point in doing a
> stop-gap fix if we already have some plan on how to fix it properly.

Thank you for your comment!
I will try this changing properly. But I may need much time.

Thanks,
Yoshihiro Shimoda


  parent reply	other threads:[~2009-04-10  1:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-09  4:38 [PATCH] sh7786: modify usb setup timeout judgment bug Kuninori Morimoto
2009-04-09  6:09 ` Nobuhiro Iwamatsu
2009-04-09  6:17 ` Michael Trimarchi
2009-04-09  8:12 ` morimoto.kuninori
2009-04-09  8:29 ` Michael Trimarchi
2009-04-09  8:36 ` morimoto.kuninori
2009-04-09  8:41 ` Michael Trimarchi
2009-04-09  9:09 ` morimoto.kuninori
2009-04-09  9:42 ` Yoshihiro Shimoda
2009-04-09 10:04 ` Michael Trimarchi
2009-04-09 11:08 ` Yoshihiro Shimoda
2009-04-09 15:09 ` Paul Mundt
2009-04-10  0:27 ` morimoto.kuninori
2009-04-10  1:24 ` Yoshihiro Shimoda [this message]
2009-04-10  4:56 ` morimoto.kuninori
2009-04-10 22:22 ` Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49DE9FD0.8080208@renesas.com \
    --to=shimoda.yoshihiro@renesas.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox