Re: [PATCH 3/6] Add USB support for SH7724

[Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>]

Hi Magnus-san,

Magnus Damm wrote:
> Hi again Morimoto-san,
> 
> [CC Shimoda-san]
> 
> On Wed, Apr 15, 2009 at 8:49 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> On Wed, Apr 15, 2009 at 11:42 AM, Kuninori Morimoto
>> <morimoto.kuninori@renesas.com> wrote:
>>> +++ b/arch/sh/kernel/cpu/sh4a/setup-sh7724.c
> 
>>> +#define UPONCR0                0xa40501d4
>>> +#define UPONCR1                0xa4050192
>>> +#define USBPOWERON     0x0600
>>> +static void __init sh7724_usb_setup(void)
>>> +{
>>> +       /*
>>> +        * USB initial settings
>>> +        *
>>> +        * The following settings are necessary
>>> +        * for using the USB modules.
>>> +        *
>>> +        * see "USB Inital Settings" for detail
>>> +        */
>>> +       __raw_writew(USBPOWERON , UPONCR0);
>>> +       __raw_writew(USBPOWERON , UPONCR1);
>>> +}
>> Hm... In the future we want to control the above dynamically for
>> better power savings. I guess it's ok as-is for now.
> 
> Looking a bit in r8a66597.h, I wonder if USBPOWERON is similar to
> VBOUT that is present in DVSTCR on external devices?

I also think UPONCR register control port power. I think this register
differ from SH7786.
I will modify the r8a66597 driver and be able to control those registers
with r8a66597's ops. It's like a sh_mobile_lcdcfb's display_on function. :)

Thanks,
Yoshihiro Shimoda