public inbox for linux-sh@vger.kernel.org
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <shimoda.yoshihiro@renesas.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] usb: r8a66597-hcd: use platform_data instead of
Date: Tue, 26 May 2009 05:00:25 +0000	[thread overview]
Message-ID: <4A1B7769.2000303@renesas.com> (raw)
In-Reply-To: <4A1B5D7C.6070205@renesas.com>

Hi Paul,

Paul Mundt wrote:
> On Tue, May 26, 2009 at 12:09:48PM +0900, Yoshihiro Shimoda wrote:
>> +struct r8a66597_platdata {
< snip >
>> +	/* set one = low level, set zero = falling edge */
>> +	unsigned	irq_sense:1;
>> +};
> 
> I would just get rid of irq_sense entirely. You can OR in
> IRQF_TRIGGER_LOW or IRQF_TRIGGER_FALLING against IORESOURCE_IRQ in the
> struct resource, so there is no need for reproducing this information
> elsewhere.

Thank you very much for your comment.
I did not notice it reproducing. I will fix this code.

Thanks,
Yoshihiro Shimoda

      parent reply	other threads:[~2009-05-26  5:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-26  3:09 [PATCH] usb: r8a66597-hcd: use platform_data instead of module_param Yoshihiro Shimoda
2009-05-26  3:22 ` Paul Mundt
2009-05-26  5:00 ` Yoshihiro Shimoda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A1B7769.2000303@renesas.com \
    --to=shimoda.yoshihiro@renesas.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox