From: Stuart MENEFY <stuart.menefy@st.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: include empty zero page in zImage
Date: Thu, 03 Dec 2009 13:48:15 +0000 [thread overview]
Message-ID: <4B17C19F.2080305@st.com> (raw)
In-Reply-To: <20091203122619.9975.58412.sendpatchset@rxone.opensource.se>
Magnus
If you do this won't you overwrite any parameters from the boot loader?
Stuart
Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Include the empty zero page data in the zImage.
> Without this patch the empty zero page may be
> uninitialized.
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
>
> I suppose we should have a fallback option to
> allow boot loaders passing data in the zero page.
> Or perhaps doing it the other way around is better.
>
> arch/sh/boot/compressed/Makefile | 2 --
> arch/sh/boot/compressed/misc.c | 2 +-
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> --- 0001/arch/sh/boot/compressed/Makefile
> +++ work/arch/sh/boot/compressed/Makefile 2009-12-03 21:06:02.000000000 +0900
> @@ -48,8 +48,6 @@ $(obj)/vmlinux.bin.bz2: $(vmlinux.bin.al
> $(obj)/vmlinux.bin.lzma: $(vmlinux.bin.all-y) FORCE
> $(call if_changed,lzma)
>
> -OBJCOPYFLAGS += -R .empty_zero_page
> -
> LDFLAGS_piggy.o := -r --format binary --oformat $(ld-bfd) -T
>
> $(obj)/piggy.o: $(obj)/vmlinux.scr $(obj)/vmlinux.bin.$(suffix-y) FORCE
> --- 0001/arch/sh/boot/compressed/misc.c
> +++ work/arch/sh/boot/compressed/misc.c 2009-12-03 21:05:58.000000000 +0900
> @@ -131,7 +131,7 @@ void decompress_kernel(void)
> #ifdef CONFIG_SUPERH64
> output_addr = (CONFIG_MEMORY_START + 0x2000);
> #else
> - output_addr = __pa((unsigned long)&_text+PAGE_SIZE);
> + output_addr = __pa((unsigned long)&_text);
> #ifdef CONFIG_29BIT
> output_addr |= P2SEG;
> #endif
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2009-12-03 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 12:26 [PATCH] sh: include empty zero page in zImage Magnus Damm
2009-12-03 13:48 ` Stuart MENEFY [this message]
2009-12-03 14:22 ` Magnus Damm
2009-12-03 21:09 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B17C19F.2080305@st.com \
--to=stuart.menefy@st.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).