From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Date: Sat, 09 Jan 2010 00:30:18 +0000 Subject: Re: [PATCH] Makefile: do not override LC_CTYPE Message-Id: <4B47CE1A.8070708@redhat.com> List-Id: References: <20100108115745.GA14758@sepie.suse.cz> <1262952988-16563-1-git-send-email-mmarek@suse.cz> <4B47C94E.8070302@redhat.com> <4B47CACA.7080103@zytor.com> In-Reply-To: <4B47CACA.7080103@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "H. Peter Anvin" Cc: Michal Marek , Simon Horman , Roland Dreier , Sam Ravnborg , Sergei Trofimovich , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org H. Peter Anvin wrote: > On 01/08/2010 04:09 PM, Masami Hiramatsu wrote: >> Hi Michal, >> >> Michal Marek wrote: >>> Setting LC_CTYPE=C breaks localized messages in some setups. With only >>> LC_COLLATE=C and LC_NUMERIC=C, we get almost all we need, except for not >>> so defined character classes and tolower()/toupper(). The former is not >>> a big issue, because we can assume that e.g. [:alpha:] will always >>> include a-zA-Z and we only ever process ASCII input. The latter seems >>> only affect arch/sh/tools/gen-mach-types, which we can handle separately. >> >> Hmm, this also affects arch/x/tools/gen-insn-attr-x86.awk. >> Could you also wrap it? >> > > This is tolower/toupper()? Do there exist locales where tolower/toupper > on ASCII input do weird things, or are we merely hypothesizing? Isn't it affect [A-Z] or [a-z]? If not, the patch good to me too. Thank you, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com