From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Fri, 15 Jan 2010 08:06:16 +0000 Subject: Re: [PATCH] cpuinfo_op: consolidate extern declaration Message-Id: <4B5021F8.4010703@monstr.eu> List-Id: References: <201001141158.09795.hartleys@visionengravers.com> In-Reply-To: <201001141158.09795.hartleys@visionengravers.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: H Hartley Sweeten Cc: Linux Kernel , linux-sh@vger.kernel.org, microblaze-uclinux@itee.uq.edu.au, x86@kernel.org, mingo@redhat.com, tglx@linutronix.de, lethal@linux-sh.org, hpa@zytor.com H Hartley Sweeten wrote: > cpuinfo_op: consolidate extern declaration > > All the architectures supported by the kernel also support > /proc/cpuinfo. Only a couple actually declare the seq_operations > as extern. All the others will produce a sparse warning like: > > warning: symbol 'cpuinfo_op' was not declared. Should it be static? > > Fix all the warnings and consolidate the declaration by putting it > in . > > Signed-off-by: H Hartley Sweeten > Cc: Ingo Molnar > Cc: Thomas Gleixner > Cc: Michal Simek > Cc: Paul Mundt > Cc: H. Peter Anvin > Tested-by: Michal Simek -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian