From: NISHIMOTO Hiroki <nishimoto.hiroki@renesas.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: mach-shmobile: pfc-sh7377: modify KEYIN settings
Date: Mon, 22 Feb 2010 07:32:28 +0000 [thread overview]
Message-ID: <4B82330C.9050200@renesas.com> (raw)
In-Reply-To: <ur5ohpsh7.wl%morimoto.kuninori@renesas.com>
I tested this patch and found that it made the keysc behavior worse.
Please stop applying the patch.
I will investigate the cause of the issue and send a patch latar.
thanks,
Kuninori Morimoto さんは書きました:
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@renesas.com>
> ---
> arch/arm/mach-shmobile/pfc-sh7377.c | 17 +++++++++--------
> 1 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/pfc-sh7377.c b/arch/arm/mach-shmobile/pfc-sh7377.c
> index 79b53d8..613e684 100644
> --- a/arch/arm/mach-shmobile/pfc-sh7377.c
> +++ b/arch/arm/mach-shmobile/pfc-sh7377.c
> @@ -102,6 +102,7 @@ enum {
> PORT_265(FN7), /* PORT0_FN7 -> PORT264_FN7 */
>
> MSELBCR_MSEL17_1, MSELBCR_MSEL17_0,
> + MSELBCR_MSEL16_1, MSELBCR_MSEL16_0,
> PINMUX_FUNCTION_END,
>
> PINMUX_MARK_BEGIN,
> @@ -528,19 +529,19 @@ static pinmux_enum_t pinmux_data[] = {
> PORT_DATA_IO_PU_PD(263),
>
> /* Special Pull-up / Pull-down Functions */
> - PINMUX_DATA(PORT66_KEYIN0_PU_MARK, MSELBCR_MSEL17_0,
> + PINMUX_DATA(PORT66_KEYIN0_PU_MARK, MSELBCR_MSEL17_0, MSELBCR_MSEL16_0,
> PORT66_FN2, PORT66_IN_PU),
> - PINMUX_DATA(PORT67_KEYIN1_PU_MARK, MSELBCR_MSEL17_0,
> + PINMUX_DATA(PORT67_KEYIN1_PU_MARK, MSELBCR_MSEL17_0, MSELBCR_MSEL16_0,
> PORT67_FN2, PORT67_IN_PU),
> - PINMUX_DATA(PORT68_KEYIN2_PU_MARK, MSELBCR_MSEL17_0,
> + PINMUX_DATA(PORT68_KEYIN2_PU_MARK, MSELBCR_MSEL17_0, MSELBCR_MSEL16_0,
> PORT68_FN2, PORT68_IN_PU),
> - PINMUX_DATA(PORT69_KEYIN3_PU_MARK, MSELBCR_MSEL17_0,
> + PINMUX_DATA(PORT69_KEYIN3_PU_MARK, MSELBCR_MSEL17_0, MSELBCR_MSEL16_0,
> PORT69_FN2, PORT69_IN_PU),
> - PINMUX_DATA(PORT70_KEYIN4_PU_MARK, MSELBCR_MSEL17_0,
> + PINMUX_DATA(PORT70_KEYIN4_PU_MARK, MSELBCR_MSEL17_0, MSELBCR_MSEL16_0,
> PORT70_FN2, PORT70_IN_PU),
> - PINMUX_DATA(PORT71_KEYIN5_PU_MARK, MSELBCR_MSEL17_0,
> + PINMUX_DATA(PORT71_KEYIN5_PU_MARK, MSELBCR_MSEL17_0, MSELBCR_MSEL16_0,
> PORT71_FN2, PORT71_IN_PU),
> - PINMUX_DATA(PORT72_KEYIN6_PU_MARK, MSELBCR_MSEL17_0,
> + PINMUX_DATA(PORT72_KEYIN6_PU_MARK, MSELBCR_MSEL17_0, MSELBCR_MSEL16_0,
> PORT72_FN2, PORT72_IN_PU),
>
>
> @@ -1637,7 +1638,7 @@ static struct pinmux_cfg_reg pinmux_config_regs[] = {
> 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> MSELBCR_MSEL17_0, MSELBCR_MSEL17_1,
> - 0, 0,
> + MSELBCR_MSEL16_0, MSELBCR_MSEL16_1,
> 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }
> },
>
next prev parent reply other threads:[~2010-02-22 7:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 7:52 [PATCH] ARM: mach-shmobile: pfc-sh7377: modify KEYIN settings Kuninori Morimoto
2010-02-22 7:32 ` NISHIMOTO Hiroki [this message]
2010-02-22 7:41 ` Paul Mundt
2010-02-23 0:58 ` NISHIMOTO Hiroki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B82330C.9050200@renesas.com \
--to=nishimoto.hiroki@renesas.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).