Re: [PATCH v2] sh_tmu: compute mult and shift before registration

[Aurelien Jarno <aurelien@aurel32.net>]

Paul Mundt a écrit :
> On Mon, May 31, 2010 at 11:45:48PM +0200, Aurelien Jarno wrote:
>> Since commit 98962465ed9e6ea99c38e0af63fe1dcb5a79dc25 ("nohz: Prevent
>> clocksource wrapping during idle"), the CPU of an R2D board never goes
>> to idle. This commit assumes that mult and shift are assigned before
>> the clocksource is registered. As a consequence the safe maximum sleep
>> time is negative and the CPU never goes into idle.
>>
>> This patch fixes the problem by moving mult and shift initialization
>> from sh_tmu_clocksource_enable() to sh_tmu_register_clocksource().
>>
>> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> 
> Applied, thanks.
> 
> I've made a similar change for the sh_cmt driver, too.
> 
> Both of these should show up in the next 2.6.34-stable release.
> 

Thanks!


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net