From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Hannemann Date: Mon, 16 Aug 2010 06:59:28 +0000 Subject: Re: [PATCH][RFC] ARM: mach-shmobile: AP4EVB: use gpio-leds for leds. Message-Id: <4C68E1D0.3040306@arndnet.de> List-Id: References: <1281815121-3724-1-git-send-email-arnd@arndnet.de> In-Reply-To: <1281815121-3724-1-git-send-email-arnd@arndnet.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org Hi Paul, Am 16.08.2010 06:23, schrieb Paul Mundt: > On Sat, Aug 14, 2010 at 09:45:21PM +0200, Arnd Hannemann wrote: >> This allows control of the leds on the AP4EVB board by kernel >> events (triggers) like mmc0/mmc1. In userland, the leds won't be >> available anymore over /sys/class/gpio but via /sys/class/leds. >> >> Signed-off-by: Arnd Hannemann > > A few minor nits. For starters, your editor has added trailing > whitespace all over the place, so please run future patches through > checkpatch for basic sanity checks first. Ok, will do and resend. >> +static struct gpio_led ap4evb_leds[] = { > [snip] >> +}; + +static struct gpio_led_platform_data ap4evb_leds_pdata = { + >> .num_leds = ARRAY_SIZE(ap4evb_leds), + .leds = &ap4evb_leds, +}; + > Here you obviously want .leds = ap4evb_leds. Has this been tested? Yes, this has been tested, I wonder why it worked... > I'll apply it with those fixes, since it's a reasonable direction to > go. Thanks, Arnd