Re: [PATCH 5/6] ARM: Make oprofile depend on CONFIG_HW_PERF_EVENTS

Sergei Shtylyov
2010-09-13T09:22:42Z

Hello.

On 13-09-2010 10:07, Matt Fleming wrote:

> Currently, oprofile support is only functional if CONFIG_HW_PERF_EVENTS
> is set. If this symbol is not set, oprofile initialisation will fail at
> runtime. Instead of allowing the oprofile code to build but fail at
> runtime it seems less confusing to not allow the code to be built unless
> hardware performance counter support is available.

> Signed-off-by: Matt Fleming<matt@console-pimps.org>
> ---
> arch/arm/Kconfig | 2 +-
> arch/arm/oprofile/common.c | 9 ---------
> 2 files changed, 1 insertions(+), 10 deletions(-)

> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index a7ed21f..d29075c 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -14,7 +14,7 @@ config ARM
> select RTC_LIB
> select SYS_SUPPORTS_APM_EMULATION
> select GENERIC_ATOMIC64 if (!CPU_32v6K)
> - select HAVE_OPROFILE if (HAVE_PERF_EVENTS)
> + select HAVE_OPROFILE if (HW_PERF_EVENTS)

Could remove useless parens while at it...

WBR, Sergei