build error in ehci-hcd when disable PCI bus

linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* build error in ehci-hcd when disable PCI bus
@ 2011-02-02  3:44 Yoshihiro Shimoda
  2011-02-02  4:39 ` Nobuhiro Iwamatsu
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Yoshihiro Shimoda @ 2011-02-02  3:44 UTC (permalink / raw)
  To: linux-sh

Hi Paul,

I found the build error when I am debugging other board.
Also I can duplicate this issue on sdk7786 when the PCI bus is disabled.
I tested linux-2.6.38-rc3.
Do you think what souce code should I fix?

******* build Log *******
In file included from drivers/usb/host/ehci-hcd.c:340:
drivers/usb/host/ehci-sched.c: In function ‘ehci_quirk_amd_L1’:
drivers/usb/host/ehci-sched.c:1606: error: implicit declaration of function ‘outb_p’
drivers/usb/host/ehci-sched.c:1607: error: implicit declaration of function ‘inb_p’
drivers/usb/host/ehci-sched.c:1611: error: implicit declaration of function ‘outl_p’
drivers/usb/host/ehci-sched.c:1614: error: implicit declaration of function ‘inl_p’
make[3]: *** [drivers/usb/host/ehci-hcd.o] Error 1
**************************

Best regards,
Yoshihiro Shimoda


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: build error in ehci-hcd when disable PCI bus
  2011-02-02  3:44 build error in ehci-hcd when disable PCI bus Yoshihiro Shimoda
@ 2011-02-02  4:39 ` Nobuhiro Iwamatsu
  2011-02-02 23:36 ` Paul Mundt
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Nobuhiro Iwamatsu @ 2011-02-02  4:39 UTC (permalink / raw)
  To: linux-sh

Hi, Shimoda-san.

2011/2/2 Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>:
> Hi Paul,
>
> I found the build error when I am debugging other board.
> Also I can duplicate this issue on sdk7786 when the PCI bus is disabled.
> I tested linux-2.6.38-rc3.
> Do you think what souce code should I fix?
>
> ******* build Log *******
> In file included from drivers/usb/host/ehci-hcd.c:340:
> drivers/usb/host/ehci-sched.c: In function ‘ehci_quirk_amd_L1’:
> drivers/usb/host/ehci-sched.c:1606: error: implicit declaration of function ‘outb_p’
> drivers/usb/host/ehci-sched.c:1607: error: implicit declaration of function ‘inb_p’
> drivers/usb/host/ehci-sched.c:1611: error: implicit declaration of function ‘outl_p’
> drivers/usb/host/ehci-sched.c:1614: error: implicit declaration of function ‘inl_p’
> make[3]: *** [drivers/usb/host/ehci-hcd.o] Error 1
> **************************

I am working to  convert from in/out to __raw_read/__raw_write now in arch/sh .

Best regaerds,
  Nobuhiro

-- 
Nobuhiro Iwamatsu

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: build error in ehci-hcd when disable PCI bus
  2011-02-02  3:44 build error in ehci-hcd when disable PCI bus Yoshihiro Shimoda
  2011-02-02  4:39 ` Nobuhiro Iwamatsu
@ 2011-02-02 23:36 ` Paul Mundt
  2011-02-02 23:44 ` Nobuhiro Iwamatsu
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Paul Mundt @ 2011-02-02 23:36 UTC (permalink / raw)
  To: linux-sh

On Wed, Feb 02, 2011 at 12:44:01PM +0900, Yoshihiro Shimoda wrote:
> I found the build error when I am debugging other board.
> Also I can duplicate this issue on sdk7786 when the PCI bus is disabled.
> I tested linux-2.6.38-rc3.
> Do you think what souce code should I fix?
> 
> ******* build Log *******
> In file included from drivers/usb/host/ehci-hcd.c:340:
> drivers/usb/host/ehci-sched.c: In function ?ehci_quirk_amd_L1?:
> drivers/usb/host/ehci-sched.c:1606: error: implicit declaration of function ?outb_p?
> drivers/usb/host/ehci-sched.c:1607: error: implicit declaration of function ?inb_p?
> drivers/usb/host/ehci-sched.c:1611: error: implicit declaration of function ?outl_p?
> drivers/usb/host/ehci-sched.c:1614: error: implicit declaration of function ?inl_p?
> make[3]: *** [drivers/usb/host/ehci-hcd.o] Error 1
> **************************
> 
When the PCI bus is disabled we don't really have any concept of PIO, so
PIO support and the associated accessors are explicitly disabled.

The quirk this refers to looks like it may depend on PCI, and if not, it
certainly has a platform dependency that can be used to encapsulate it.

The proper fix here is to fix ehci-sched.c, not re-introduce broken PIO
crap that wraps in to MMIO.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: build error in ehci-hcd when disable PCI bus
  2011-02-02  3:44 build error in ehci-hcd when disable PCI bus Yoshihiro Shimoda
  2011-02-02  4:39 ` Nobuhiro Iwamatsu
  2011-02-02 23:36 ` Paul Mundt
@ 2011-02-02 23:44 ` Nobuhiro Iwamatsu
  2011-02-02 23:46 ` Nobuhiro Iwamatsu
  2011-02-03  1:29 ` Yoshihiro Shimoda
  4 siblings, 0 replies; 6+ messages in thread
From: Nobuhiro Iwamatsu @ 2011-02-02 23:44 UTC (permalink / raw)
  To: linux-sh

2011/2/3 Paul Mundt <lethal@linux-sh.org>:
> On Wed, Feb 02, 2011 at 12:44:01PM +0900, Yoshihiro Shimoda wrote:
>> I found the build error when I am debugging other board.
>> Also I can duplicate this issue on sdk7786 when the PCI bus is disabled.
>> I tested linux-2.6.38-rc3.
>> Do you think what souce code should I fix?
>>
>> ******* build Log *******
>> In file included from drivers/usb/host/ehci-hcd.c:340:
>> drivers/usb/host/ehci-sched.c: In function ?ehci_quirk_amd_L1?:
>> drivers/usb/host/ehci-sched.c:1606: error: implicit declaration of function ?outb_p?
>> drivers/usb/host/ehci-sched.c:1607: error: implicit declaration of function ?inb_p?
>> drivers/usb/host/ehci-sched.c:1611: error: implicit declaration of function ?outl_p?
>> drivers/usb/host/ehci-sched.c:1614: error: implicit declaration of function ?inl_p?
>> make[3]: *** [drivers/usb/host/ehci-hcd.o] Error 1
>> **************************
>>
> When the PCI bus is disabled we don't really have any concept of PIO, so
> PIO support and the associated accessors are explicitly disabled.
>
> The quirk this refers to looks like it may depend on PCI, and if not, it
> certainly has a platform dependency that can be used to encapsulate it.
>
> The proper fix here is to fix ehci-sched.c, not re-introduce broken PIO
> crap that wraps in to MMIO.

Are these same to other devices?
Some device driver depends on PIO.

-- 
Nobuhiro Iwamatsu

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: build error in ehci-hcd when disable PCI bus
  2011-02-02  3:44 build error in ehci-hcd when disable PCI bus Yoshihiro Shimoda
                   ` (2 preceding siblings ...)
  2011-02-02 23:44 ` Nobuhiro Iwamatsu
@ 2011-02-02 23:46 ` Nobuhiro Iwamatsu
  2011-02-03  1:29 ` Yoshihiro Shimoda
  4 siblings, 0 replies; 6+ messages in thread
From: Nobuhiro Iwamatsu @ 2011-02-02 23:46 UTC (permalink / raw)
  To: linux-sh

Sorry, I got advice from you in other threads.

2011/2/3 Nobuhiro Iwamatsu <iwamatsu@nigauri.org>:
> 2011/2/3 Paul Mundt <lethal@linux-sh.org>:
>> On Wed, Feb 02, 2011 at 12:44:01PM +0900, Yoshihiro Shimoda wrote:
>>> I found the build error when I am debugging other board.
>>> Also I can duplicate this issue on sdk7786 when the PCI bus is disabled.
>>> I tested linux-2.6.38-rc3.
>>> Do you think what souce code should I fix?
>>>
>>> ******* build Log *******
>>> In file included from drivers/usb/host/ehci-hcd.c:340:
>>> drivers/usb/host/ehci-sched.c: In function ?ehci_quirk_amd_L1?:
>>> drivers/usb/host/ehci-sched.c:1606: error: implicit declaration of function ?outb_p?
>>> drivers/usb/host/ehci-sched.c:1607: error: implicit declaration of function ?inb_p?
>>> drivers/usb/host/ehci-sched.c:1611: error: implicit declaration of function ?outl_p?
>>> drivers/usb/host/ehci-sched.c:1614: error: implicit declaration of function ?inl_p?
>>> make[3]: *** [drivers/usb/host/ehci-hcd.o] Error 1
>>> **************************
>>>
>> When the PCI bus is disabled we don't really have any concept of PIO, so
>> PIO support and the associated accessors are explicitly disabled.
>>
>> The quirk this refers to looks like it may depend on PCI, and if not, it
>> certainly has a platform dependency that can be used to encapsulate it.
>>
>> The proper fix here is to fix ehci-sched.c, not re-introduce broken PIO
>> crap that wraps in to MMIO.
>
> Are these same to other devices?
> Some device driver depends on PIO.
>
> --
> Nobuhiro Iwamatsu
>



-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: build error in ehci-hcd when disable PCI bus
  2011-02-02  3:44 build error in ehci-hcd when disable PCI bus Yoshihiro Shimoda
                   ` (3 preceding siblings ...)
  2011-02-02 23:46 ` Nobuhiro Iwamatsu
@ 2011-02-03  1:29 ` Yoshihiro Shimoda
  4 siblings, 0 replies; 6+ messages in thread
From: Yoshihiro Shimoda @ 2011-02-03  1:29 UTC (permalink / raw)
  To: linux-sh

Hi Paul-san,

2011/02/03 8:36, Paul Mundt wrote:
> When the PCI bus is disabled we don't really have any concept of PIO, so
> PIO support and the associated accessors are explicitly disabled.
> 
> The quirk this refers to looks like it may depend on PCI, and if not, it
> certainly has a platform dependency that can be used to encapsulate it.
> 
> The proper fix here is to fix ehci-sched.c, not re-introduce broken PIO
> crap that wraps in to MMIO.

Thank you very much for your reply.
I will report it to linux-usb ml.

Best regards,
Yoshihiro Shimoda

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-02-03  1:29 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-02  3:44 build error in ehci-hcd when disable PCI bus Yoshihiro Shimoda
2011-02-02  4:39 ` Nobuhiro Iwamatsu
2011-02-02 23:36 ` Paul Mundt
2011-02-02 23:44 ` Nobuhiro Iwamatsu
2011-02-02 23:46 ` Nobuhiro Iwamatsu
2011-02-03  1:29 ` Yoshihiro Shimoda

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).