From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: linux-sh@vger.kernel.org
Subject: Re: [RFC, PATCH 1/4] net: sh_eth: modify the definitions of register
Date: Thu, 17 Feb 2011 06:51:35 +0000 [thread overview]
Message-ID: <4D5CC577.5010108@renesas.com> (raw)
In-Reply-To: <4D5A67CC.80107@renesas.com>
2011/02/17 9:56, Nobuhiro Iwamatsu wrote:
> 2011/2/17 Nobuhiro Iwamatsu <iwamatsu@nigauri.org>:
>>> +static const u16 *sh_eth_get_register_offset(int register_type)
>>> +{
>>> + const u16 *reg_offset = NULL;
>>> +
>>> + switch (register_type) {
>>> + case SH_ETH_REG_GIGABIT:
>>> + reg_offset = sh_eth_offset_gigabit;
>>> + break;
>>> + case SH_ETH_REG_FAST_SH4:
>>> + reg_offset = sh_eth_offset_fast_sh4;
>>> + break;
>>> + case SH_ETH_REG_FAST_SH3_SH2:
>>> + reg_offset = sh_eth_offset_fast_sh3_sh2;
>>> + break;
>>> + case SH_ETH_REG_DEFAULT:
>>> +#if defined(CONFIG_CPU_SUBTYPE_SH7763)
>>> + reg_offset = sh_eth_offset_gigabit;
>>> +#elif defined(CONFIG_CPU_SH4)
>>> + reg_offset = sh_eth_offset_fast_sh4;
>>> +#else
>>> + reg_offset = sh_eth_offset_fast_sh3_sh2;
>>> +#endif
>>> + break;
>>> + default:
>>> + printk(KERN_ERR "Unknown register type (%d)\n", register_type);
>>> + break;
>>> + }
>>> +
>>> + return reg_offset;
>>> +}
>>> +
>>
>> Is the handling of SH_ETH_REG_DEFAULT necessary?
Thank you for your review!
No, it isn't necessary. I will remove it and I will add NULL checking of mdp->reg_offset.
Best regards,
Yoshihiro Shimoda
prev parent reply other threads:[~2011-02-17 6:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 11:47 [RFC, PATCH 1/4] net: sh_eth: modify the definitions of register Yoshihiro Shimoda
2011-02-17 0:21 ` Nobuhiro Iwamatsu
2011-02-17 0:56 ` Nobuhiro Iwamatsu
2011-02-17 6:51 ` Yoshihiro Shimoda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5CC577.5010108@renesas.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).