From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] usb: add EHCI and OHCI support for SH7757
Date: Mon, 28 Feb 2011 04:40:54 +0000 [thread overview]
Message-ID: <4D6B2756.7070601@renesas.com> (raw)
In-Reply-To: <4D660C04.9070800@renesas.com>
Hi David,
2011/02/26 3:41, David Daney wrote:
>> diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
>> index 759a12f..257974e 100644
>> --- a/drivers/usb/host/ohci-hcd.c
>> +++ b/drivers/usb/host/ohci-hcd.c
>> @@ -1070,6 +1070,7 @@ MODULE_LICENSE ("GPL");
>>
>> #if defined(CONFIG_CPU_SUBTYPE_SH7720) || \
>> defined(CONFIG_CPU_SUBTYPE_SH7721) || \
>> + defined(CONFIG_CPU_SUBTYPE_SH7757) || \
>> defined(CONFIG_CPU_SUBTYPE_SH7763) || \
>> defined(CONFIG_CPU_SUBTYPE_SH7786)
>> #include "ohci-sh.c"
>
> I wonder if all that #ifdefery could be moved into the arch/sh Kconfig.
>
> Patching the core ehci/ohci code each time a new sh CPU variant is
> released seems like the wrong approach.
Thank you very much for your comment. I think so.
So I will move it into the drivers/usb/host Kconfig because
the Kconfig has some configs for architecture dependency.
Best regards,
Yoshihiro Shimoda
> David Daney
>
prev parent reply other threads:[~2011-02-28 4:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 7:43 [PATCH] usb: add EHCI and OHCI support for SH7757 Yoshihiro Shimoda
2011-02-24 8:16 ` Kuninori Morimoto
2011-02-24 8:35 ` Yoshihiro Shimoda
2011-02-24 9:47 ` Yoshihiro Shimoda
2011-02-24 11:26 ` Sergei Shtylyov
2011-02-25 0:26 ` Yoshihiro Shimoda
2011-02-25 3:19 ` Paul Mundt
2011-02-25 4:26 ` Yoshihiro Shimoda
2011-02-25 18:41 ` David Daney
2011-02-25 19:39 ` Greg KH
2011-02-28 4:40 ` Yoshihiro Shimoda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6B2756.7070601@renesas.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).