* Re: [PATCH] usb: add EHCI and OHCI support for SH7757
2011-02-24 7:43 [PATCH] usb: add EHCI and OHCI support for SH7757 Yoshihiro Shimoda
@ 2011-02-24 8:16 ` Kuninori Morimoto
2011-02-24 8:35 ` Yoshihiro Shimoda
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Kuninori Morimoto @ 2011-02-24 8:16 UTC (permalink / raw)
To: linux-sh
Dear Shimoda san
> -#ifdef CONFIG_CPU_SUBTYPE_SH7786
> +#if defined(CONFIG_CPU_SUBTYPE_SH7757) || \
> + defined(CONFIG_CPU_SUBTYPE_SH7785)
Is this miss ?
you remove 7786
and add 7785 ?
~
Best regards
--
Kuninori Morimoto
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] usb: add EHCI and OHCI support for SH7757
2011-02-24 7:43 [PATCH] usb: add EHCI and OHCI support for SH7757 Yoshihiro Shimoda
2011-02-24 8:16 ` Kuninori Morimoto
@ 2011-02-24 8:35 ` Yoshihiro Shimoda
2011-02-24 9:47 ` Yoshihiro Shimoda
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Yoshihiro Shimoda @ 2011-02-24 8:35 UTC (permalink / raw)
To: linux-sh
Dear Morimoto-san,
2011/02/24 17:16, Kuninori Morimoto wrote:
>
> Dear Shimoda san
>
>> -#ifdef CONFIG_CPU_SUBTYPE_SH7786
>> +#if defined(CONFIG_CPU_SUBTYPE_SH7757) || \
>> + defined(CONFIG_CPU_SUBTYPE_SH7785)
>
> Is this miss ?
> you remove 7786
> and add 7785 ?
Oh, Thank you very much! I mistook the code.
I must keep the 7786 and I would like to add 7757.
I will fix it.
Best regards,
Yoshihiro Shimoda
> ~
>
> Best regards
> --
> Kuninori Morimoto
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH] usb: add EHCI and OHCI support for SH7757
2011-02-24 7:43 [PATCH] usb: add EHCI and OHCI support for SH7757 Yoshihiro Shimoda
2011-02-24 8:16 ` Kuninori Morimoto
2011-02-24 8:35 ` Yoshihiro Shimoda
@ 2011-02-24 9:47 ` Yoshihiro Shimoda
2011-02-24 11:26 ` Sergei Shtylyov
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Yoshihiro Shimoda @ 2011-02-24 9:47 UTC (permalink / raw)
To: linux-sh
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
about v2:
- fix the condition for other CPU in ehci-hcd.c.
drivers/usb/host/ehci-hcd.c | 3 ++-
drivers/usb/host/ohci-hcd.c | 1 +
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
index 4c77a81..b396567 100644
--- a/drivers/usb/host/ehci-hcd.c
+++ b/drivers/usb/host/ehci-hcd.c
@@ -1184,7 +1184,8 @@ MODULE_LICENSE ("GPL");
#define PLATFORM_DRIVER ehci_mxc_driver
#endif
-#ifdef CONFIG_CPU_SUBTYPE_SH7786
+#if defined(CONFIG_CPU_SUBTYPE_SH7757) || \
+ defined(CONFIG_CPU_SUBTYPE_SH7786)
#include "ehci-sh.c"
#define PLATFORM_DRIVER ehci_hcd_sh_driver
#endif
diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
index 759a12f..257974e 100644
--- a/drivers/usb/host/ohci-hcd.c
+++ b/drivers/usb/host/ohci-hcd.c
@@ -1070,6 +1070,7 @@ MODULE_LICENSE ("GPL");
#if defined(CONFIG_CPU_SUBTYPE_SH7720) || \
defined(CONFIG_CPU_SUBTYPE_SH7721) || \
+ defined(CONFIG_CPU_SUBTYPE_SH7757) || \
defined(CONFIG_CPU_SUBTYPE_SH7763) || \
defined(CONFIG_CPU_SUBTYPE_SH7786)
#include "ohci-sh.c"
--
1.7.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH] usb: add EHCI and OHCI support for SH7757
2011-02-24 7:43 [PATCH] usb: add EHCI and OHCI support for SH7757 Yoshihiro Shimoda
` (2 preceding siblings ...)
2011-02-24 9:47 ` Yoshihiro Shimoda
@ 2011-02-24 11:26 ` Sergei Shtylyov
2011-02-25 0:26 ` Yoshihiro Shimoda
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Sergei Shtylyov @ 2011-02-24 11:26 UTC (permalink / raw)
To: linux-sh
Hello.
On 24-02-2011 10:43, Yoshihiro Shimoda wrote:
> Signed-off-by: Yoshihiro Shimoda<yoshihiro.shimoda.uh@renesas.com>
[...]
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 4c77a81..b5aae43 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -1184,7 +1184,8 @@ MODULE_LICENSE ("GPL");
> #define PLATFORM_DRIVER ehci_mxc_driver
> #endif
>
> -#ifdef CONFIG_CPU_SUBTYPE_SH7786
> +#if defined(CONFIG_CPU_SUBTYPE_SH7757) || \
> + defined(CONFIG_CPU_SUBTYPE_SH7785)
Not CONFIG_CPU_SUBTYPE_SH7786?
> #include "ehci-sh.c"
> #define PLATFORM_DRIVER ehci_hcd_sh_driver
> #endif
WBR, Sergei
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] usb: add EHCI and OHCI support for SH7757
2011-02-24 7:43 [PATCH] usb: add EHCI and OHCI support for SH7757 Yoshihiro Shimoda
` (3 preceding siblings ...)
2011-02-24 11:26 ` Sergei Shtylyov
@ 2011-02-25 0:26 ` Yoshihiro Shimoda
2011-02-25 3:19 ` Paul Mundt
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Yoshihiro Shimoda @ 2011-02-25 0:26 UTC (permalink / raw)
To: linux-sh
Hello Sergei,
2011/02/24 20:26, Sergei Shtylyov wrote:
> Hello.
>
> On 24-02-2011 10:43, Yoshihiro Shimoda wrote:
>
>> Signed-off-by: Yoshihiro Shimoda<yoshihiro.shimoda.uh@renesas.com>
> [...]
>
>> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
>> index 4c77a81..b5aae43 100644
>> --- a/drivers/usb/host/ehci-hcd.c
>> +++ b/drivers/usb/host/ehci-hcd.c
>> @@ -1184,7 +1184,8 @@ MODULE_LICENSE ("GPL");
>> #define PLATFORM_DRIVER ehci_mxc_driver
>> #endif
>>
>> -#ifdef CONFIG_CPU_SUBTYPE_SH7786
>> +#if defined(CONFIG_CPU_SUBTYPE_SH7757) || \
>> + defined(CONFIG_CPU_SUBTYPE_SH7785)
>
> Not CONFIG_CPU_SUBTYPE_SH7786?
Thank you very much for your point!
I re-submitted a fixed patch yesterday.
Best regards,
Yoshihiro Shimoda
>> #include "ehci-sh.c"
>> #define PLATFORM_DRIVER ehci_hcd_sh_driver
>> #endif
>
> WBR, Sergei
>
--
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] usb: add EHCI and OHCI support for SH7757
2011-02-24 7:43 [PATCH] usb: add EHCI and OHCI support for SH7757 Yoshihiro Shimoda
` (4 preceding siblings ...)
2011-02-25 0:26 ` Yoshihiro Shimoda
@ 2011-02-25 3:19 ` Paul Mundt
2011-02-25 4:26 ` Yoshihiro Shimoda
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Paul Mundt @ 2011-02-25 3:19 UTC (permalink / raw)
To: linux-sh
On Thu, Feb 24, 2011 at 06:47:10PM +0900, Yoshihiro Shimoda wrote:
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> about v2:
> - fix the condition for other CPU in ehci-hcd.c.
>
And how exactly are you enabling this when the 7757 Kconfig entry doesn't
select either of USB_ARCH_HAS_OHCI or USB_ARCH_HAS_EHCI?
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] usb: add EHCI and OHCI support for SH7757
2011-02-24 7:43 [PATCH] usb: add EHCI and OHCI support for SH7757 Yoshihiro Shimoda
` (5 preceding siblings ...)
2011-02-25 3:19 ` Paul Mundt
@ 2011-02-25 4:26 ` Yoshihiro Shimoda
2011-02-25 18:41 ` David Daney
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Yoshihiro Shimoda @ 2011-02-25 4:26 UTC (permalink / raw)
To: linux-sh
Hi Paul,
2011/02/25 12:19, Paul Mundt wrote:
> On Thu, Feb 24, 2011 at 06:47:10PM +0900, Yoshihiro Shimoda wrote:
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> ---
>> about v2:
>> - fix the condition for other CPU in ehci-hcd.c.
>>
> And how exactly are you enabling this when the 7757 Kconfig entry doesn't
> select either of USB_ARCH_HAS_OHCI or USB_ARCH_HAS_EHCI?
>
I intended to submit a patch which modified Kconfig after this patch applied.
But I should also have submitted the patch together.
I will submit it and other necessary patches　to linux-sh ml.
Best regards,
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] usb: add EHCI and OHCI support for SH7757
2011-02-24 7:43 [PATCH] usb: add EHCI and OHCI support for SH7757 Yoshihiro Shimoda
` (6 preceding siblings ...)
2011-02-25 4:26 ` Yoshihiro Shimoda
@ 2011-02-25 18:41 ` David Daney
2011-02-25 19:39 ` Greg KH
2011-02-28 4:40 ` Yoshihiro Shimoda
9 siblings, 0 replies; 11+ messages in thread
From: David Daney @ 2011-02-25 18:41 UTC (permalink / raw)
To: linux-sh
On 02/24/2011 01:47 AM, Yoshihiro Shimoda wrote:
> Signed-off-by: Yoshihiro Shimoda<yoshihiro.shimoda.uh@renesas.com>
> ---
> about v2:
> - fix the condition for other CPU in ehci-hcd.c.
>
> drivers/usb/host/ehci-hcd.c | 3 ++-
> drivers/usb/host/ohci-hcd.c | 1 +
> 2 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 4c77a81..b396567 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -1184,7 +1184,8 @@ MODULE_LICENSE ("GPL");
> #define PLATFORM_DRIVER ehci_mxc_driver
> #endif
>
> -#ifdef CONFIG_CPU_SUBTYPE_SH7786
> +#if defined(CONFIG_CPU_SUBTYPE_SH7757) || \
> + defined(CONFIG_CPU_SUBTYPE_SH7786)
> #include "ehci-sh.c"
> #define PLATFORM_DRIVER ehci_hcd_sh_driver
> #endif
> diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
> index 759a12f..257974e 100644
> --- a/drivers/usb/host/ohci-hcd.c
> +++ b/drivers/usb/host/ohci-hcd.c
> @@ -1070,6 +1070,7 @@ MODULE_LICENSE ("GPL");
>
> #if defined(CONFIG_CPU_SUBTYPE_SH7720) || \
> defined(CONFIG_CPU_SUBTYPE_SH7721) || \
> + defined(CONFIG_CPU_SUBTYPE_SH7757) || \
> defined(CONFIG_CPU_SUBTYPE_SH7763) || \
> defined(CONFIG_CPU_SUBTYPE_SH7786)
> #include "ohci-sh.c"
I wonder if all that #ifdefery could be moved into the arch/sh Kconfig.
Patching the core ehci/ohci code each time a new sh CPU variant is
released seems like the wrong approach.
David Daney
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] usb: add EHCI and OHCI support for SH7757
2011-02-24 7:43 [PATCH] usb: add EHCI and OHCI support for SH7757 Yoshihiro Shimoda
` (7 preceding siblings ...)
2011-02-25 18:41 ` David Daney
@ 2011-02-25 19:39 ` Greg KH
2011-02-28 4:40 ` Yoshihiro Shimoda
9 siblings, 0 replies; 11+ messages in thread
From: Greg KH @ 2011-02-25 19:39 UTC (permalink / raw)
To: linux-sh
On Fri, Feb 25, 2011 at 01:26:18PM +0900, Yoshihiro Shimoda wrote:
> Hi Paul,
>
> 2011/02/25 12:19, Paul Mundt wrote:
> > On Thu, Feb 24, 2011 at 06:47:10PM +0900, Yoshihiro Shimoda wrote:
> >> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> >> ---
> >> about v2:
> >> - fix the condition for other CPU in ehci-hcd.c.
> >>
> > And how exactly are you enabling this when the 7757 Kconfig entry doesn't
> > select either of USB_ARCH_HAS_OHCI or USB_ARCH_HAS_EHCI?
> >
> I intended to submit a patch which modified Kconfig after this patch applied.
> But I should also have submitted the patch together.
> I will submit it and other necessary patches　to linux-sh ml.
Ok, then I will drop this one from my queue.
For such simple config patches, they can go through the sh tree, no need
to go through the usb one.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] usb: add EHCI and OHCI support for SH7757
2011-02-24 7:43 [PATCH] usb: add EHCI and OHCI support for SH7757 Yoshihiro Shimoda
` (8 preceding siblings ...)
2011-02-25 19:39 ` Greg KH
@ 2011-02-28 4:40 ` Yoshihiro Shimoda
9 siblings, 0 replies; 11+ messages in thread
From: Yoshihiro Shimoda @ 2011-02-28 4:40 UTC (permalink / raw)
To: linux-sh
Hi David,
2011/02/26 3:41, David Daney wrote:
>> diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
>> index 759a12f..257974e 100644
>> --- a/drivers/usb/host/ohci-hcd.c
>> +++ b/drivers/usb/host/ohci-hcd.c
>> @@ -1070,6 +1070,7 @@ MODULE_LICENSE ("GPL");
>>
>> #if defined(CONFIG_CPU_SUBTYPE_SH7720) || \
>> defined(CONFIG_CPU_SUBTYPE_SH7721) || \
>> + defined(CONFIG_CPU_SUBTYPE_SH7757) || \
>> defined(CONFIG_CPU_SUBTYPE_SH7763) || \
>> defined(CONFIG_CPU_SUBTYPE_SH7786)
>> #include "ohci-sh.c"
>
> I wonder if all that #ifdefery could be moved into the arch/sh Kconfig.
>
> Patching the core ehci/ohci code each time a new sh CPU variant is
> released seems like the wrong approach.
Thank you very much for your comment. I think so.
So I will move it into the drivers/usb/host Kconfig because
the Kconfig has some configs for architecture dependency.
Best regards,
Yoshihiro Shimoda
> David Daney
>
^ permalink raw reply [flat|nested] 11+ messages in thread