[PATCH] sh: sh-sci: Check initialization for earlyprintk

[PATCH] sh: sh-sci: Check initialization for earlyprintk

[Nobuhiro Iwamatsu]

When user do not set earlyprink, initialization is performed in the state
that setting is not performed. In this case sh-sci does not work.
This checks the initialization.

Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
---
 drivers/tty/serial/sh-sci.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
index eb7958c..cc4c329 100644
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -1836,6 +1836,9 @@ static int __devinit serial_console_setup(struct console *co, char *options)
 	sci_port = &sci_ports[co->index];
 	port = &sci_port->port;
 
+	if (port->ops = NULL)
+		return -ENODEV;
+
 	ret = sci_remap_port(port);
 	if (unlikely(ret != 0))
 		return ret;
-- 
1.7.4.1

Re: [PATCH] sh: sh-sci: Check initialization for earlyprintk

[Yoshihiro Shimoda]

Hi Iwamatsu-san,

2011/03/28 11:34, Nobuhiro Iwamatsu wrote:
> When user do not set earlyprink, initialization is performed in the state
> that setting is not performed. In this case sh-sci does not work.
> This checks the initialization.
> 
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Thank you for this patch.
I tested this patch, and confirmed that the sh-sci worked correctly.
When I didn't this patch without earlyprintk on ecovec24 and sh7757lcr,
the sh-sci didn't output any console log.

Thanks,
Yoshihiro Shimoda