From: Rob Herring <robherring2@gmail.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: mach-shmobile: AG5EVM GIC Sparse IRQ fix
Date: Tue, 22 Nov 2011 14:12:24 +0000 [thread overview]
Message-ID: <4ECBADC8.5090503@gmail.com> (raw)
In-Reply-To: <20111122063140.31045.57736.sendpatchset@w520>
On 11/22/2011 12:31 AM, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Fix IRQ support on the AG5EVM board. The sh73a0 and the AG5EVM
> board make use of the ARM GIC hardware block as main interrupt
> controller. The following commit changed the default behaviour
> for non-device tree platforms and broke AG5EVM irq support:
>
> f37a53c ARM: gic: fix irq_alloc_descs handling for sparse irq
>
> Without this fix the following warning triggers at boot:
>
> NR_IRQS:1024 nr_irqs:1024 1024
> ------------[ cut here ]------------
> WARNING: at arch/arm/common/gic.c:607 gic_init+0x90/0x2e4()
> Cannot allocate irq_descs @ IRQ16, assuming pre-allocated
> [<c000c868>] (unwind_backtrace+0x0/0xe0) from [<c001857c>] (warn_slowpath_commo)
> [<c001857c>] (warn_slowpath_common+0x48/0x60) from [<c00185d8>] (warn_slowpath_)
> [<c00185d8>] (warn_slowpath_fmt+0x2c/0x3c) from [<c029ee08>] (gic_init+0x90/0x2)
> [<c029ee08>] (gic_init+0x90/0x2e4) from [<c029f278>] (sh73a0_init_irq+0x30/0x18)
> [<c029f278>] (sh73a0_init_irq+0x30/0x184) from [<c029c0b4>] (init_IRQ+0x14/0x1c)
> [<c029c0b4>] (init_IRQ+0x14/0x1c) from [<c029a5cc>] (start_kernel+0x15c/0x2b8)
> [<c029a5cc>] (start_kernel+0x15c/0x2b8) from [<4000803c>] (0x4000803c)
> ---[ end trace 1b75b31a2719ed1c ]---
>
> With this fix applied interrupts work as expected.
>
They work without the fix as well, right?
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
For both patches:
Acked-by: Rob Herring <rob.herring@calxeda.com>
>
> arch/arm/mach-shmobile/board-ag5evm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- 0001/arch/arm/mach-shmobile/board-ag5evm.c
> +++ work/arch/arm/mach-shmobile/board-ag5evm.c 2011-11-17 18:35:51.000000000 +0900
> @@ -607,6 +607,7 @@ struct sys_timer ag5evm_timer = {
>
> MACHINE_START(AG5EVM, "ag5evm")
> .map_io = ag5evm_map_io,
> + .nr_irqs = NR_IRQS_LEGACY,
> .init_irq = sh73a0_init_irq,
> .handle_irq = shmobile_handle_irq_gic,
> .init_machine = ag5evm_init,
prev parent reply other threads:[~2011-11-22 14:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 6:31 [PATCH] ARM: mach-shmobile: AG5EVM GIC Sparse IRQ fix Magnus Damm
2011-11-22 14:12 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECBADC8.5090503@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).