From: Takashi Yoshii <takashi.yoshii.zj@renesas.com>
To: linux-sh@vger.kernel.org
Subject: Re: sh-sci CTS problem
Date: Fri, 25 Nov 2011 05:07:47 +0000 [thread overview]
Message-ID: <4ECF22A3.2000803@renesas.com> (raw)
In-Reply-To: <OFB48B001D.3AA44CAE-ON80257950.0037E14A-80257950.0039B579@eu.necel.com>
Hi,
> I guess the right thing to do is add an extra field to struct
> plat_sci_port to indicate support for RTS/CTS?
Right. I guess each real pin manipulation will be handled like sci_init_pins().
On the other hand, I don't think there is much things to do here for channels
that does *not* support control lines. get_mctrl() does not provide the function
to tell "not supported" condition anyway.
I think that should be implemented in sci_set_termios().
Currently, it sets SCFCR.MCE regardless of the HW function, and does not
fix any bits in c_flags. We can negate CRTSCTS in termios->c_cflag there,
unless (s->cfg->flags & UPF_xx) or something.
Does anyone know good flags or constant definitions?
/yoshii
prev parent reply other threads:[~2011-11-25 5:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 10:32 sh-sci CTS problem phil.edworthy
2011-11-24 9:03 ` Paul Mundt
2011-11-24 9:19 ` phil.edworthy
2011-11-25 5:07 ` Takashi Yoshii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECF22A3.2000803@renesas.com \
--to=takashi.yoshii.zj@renesas.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).