From: "Shimoda, Yoshihiro" <yoshihiro.shimoda.uh@renesas.com>
To: linux-sh@vger.kernel.org
Subject: Re: [RFC][PATCH 1/3] dmaengine: shdma: add .no_error_irq flag
Date: Tue, 10 Jan 2012 00:47:55 +0000 [thread overview]
Message-ID: <4F0B8ABB.9060009@renesas.com> (raw)
In-Reply-To: <4F0537F2.4080306@renesas.com>
2012/01/09 11:00, Paul Mundt wrote:
> On Fri, Jan 06, 2012 at 01:00:25PM +0900, Shimoda, Yoshihiro wrote:
>> -------
>> Subject: [PATCH] dmaengine: shdma: modify the DMAC Address Error registration
>>
>> The USB-DMAC/SUDMAC don't have the interrupt of DMAC Address Error.
>> So, only when the resource has a name and it is "error_irq", the driver
>> calls request_irq() for DMAC Address Error.
>>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> If we're going to do this it would be nice to adopt the same behaviour
> for the generic DMAE IRQ, too (then we can finally get rid of those silly
> CPU_SH4 || ARCH_SHMOBILE ifdefs).
>
> This approach looks like an improvement to me at least.
>
Thank you very much for your comment.
I will get rid of the "CPU_SH4 || ARCH_SHMOBILE" ifdefs.
Best regards,
Yoshihiro Shimoda
prev parent reply other threads:[~2012-01-10 0:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 5:41 [RFC][PATCH 1/3] dmaengine: shdma: add .no_error_irq flag Shimoda, Yoshihiro
2012-01-05 9:01 ` Guennadi Liakhovetski
2012-01-06 4:00 ` Shimoda, Yoshihiro
2012-01-09 2:00 ` Paul Mundt
2012-01-10 0:47 ` Shimoda, Yoshihiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0B8ABB.9060009@renesas.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).