From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Date: Fri, 13 Jan 2012 16:58:01 +0000 Subject: Re: [RFC PATCH 01/10] rtc: sa1100: include mach/irqs.h instead of asm/irq.h Message-Id: <4F106299.8050306@gmail.com> List-Id: References: <1326472451-9002-1-git-send-email-robherring2@gmail.com> <1326472451-9002-2-git-send-email-robherring2@gmail.com> <20120113164336.GA1068@n2100.arm.linux.org.uk> In-Reply-To: <20120113164336.GA1068@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 01/13/2012 10:43 AM, Russell King - ARM Linux wrote: > On Fri, Jan 13, 2012 at 10:34:02AM -0600, Rob Herring wrote: >> From: Rob Herring >> >> Since asm/irq.h may not include mach/irqs.h, include mach/irqs.h directly. > > Rather than doing this, we should be eliminating the need for these > old drivers to include mach/irqs.h at all. > > Adding the resources to the platform device, and then using at least > the IRQ resource(s) would be a definite step forward (and a relatively > easy one to do.) > Well, this has just happened in 3.3. So I can now drop this one I think. Rob >> >> Signed-off-by: Rob Herring >> --- >> drivers/rtc/rtc-sa1100.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/rtc/rtc-sa1100.c b/drivers/rtc/rtc-sa1100.c >> index 4595d3e..144fa06 100644 >> --- a/drivers/rtc/rtc-sa1100.c >> +++ b/drivers/rtc/rtc-sa1100.c >> @@ -33,7 +33,7 @@ >> #include >> >> #include >> -#include >> +#include >> >> #define RTC_DEF_DIVIDER (32768 - 1) >> #define RTC_DEF_TRIM 0 >> -- >> 1.7.5.4 >>