linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RESEND] mmc: sh_mmcif: fix MMC_GEN_CMD setting
@ 2012-03-07  8:37 Shimoda, Yoshihiro
  2012-03-09  4:47 ` Chris Ball
  0 siblings, 1 reply; 2+ messages in thread
From: Shimoda, Yoshihiro @ 2012-03-07  8:37 UTC (permalink / raw)
  To: cjb; +Cc: linux-mmc, SH-Linux

The MMC_GEN_CMD (CMD56) doesn't need to check busy signal.
So, the patch fixes the setting.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 drivers/mmc/host/sh_mmcif.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
index 4a2c5b2..e8b70e3 100644
--- a/drivers/mmc/host/sh_mmcif.c
+++ b/drivers/mmc/host/sh_mmcif.c
@@ -745,7 +745,6 @@ static u32 sh_mmcif_set_cmd(struct sh_mmcif_host *host,
 	case MMC_SET_WRITE_PROT:
 	case MMC_CLR_WRITE_PROT:
 	case MMC_ERASE:
-	case MMC_GEN_CMD:
 		tmp |= CMD_SET_RBSY;
 		break;
 	}
@@ -828,7 +827,6 @@ static void sh_mmcif_start_cmd(struct sh_mmcif_host *host,
 	case MMC_SET_WRITE_PROT:
 	case MMC_CLR_WRITE_PROT:
 	case MMC_ERASE:
-	case MMC_GEN_CMD:
 		mask = MASK_START_CMD | MASK_MRBSYE;
 		break;
 	default:
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH RESEND] mmc: sh_mmcif: fix MMC_GEN_CMD setting
  2012-03-07  8:37 [PATCH RESEND] mmc: sh_mmcif: fix MMC_GEN_CMD setting Shimoda, Yoshihiro
@ 2012-03-09  4:47 ` Chris Ball
  0 siblings, 0 replies; 2+ messages in thread
From: Chris Ball @ 2012-03-09  4:47 UTC (permalink / raw)
  To: Shimoda, Yoshihiro; +Cc: linux-mmc, SH-Linux

Hi,

On Wed, Mar 07 2012, Shimoda, Yoshihiro wrote:
> The MMC_GEN_CMD (CMD56) doesn't need to check busy signal.
> So, the patch fixes the setting.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
>  drivers/mmc/host/sh_mmcif.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
> index 4a2c5b2..e8b70e3 100644
> --- a/drivers/mmc/host/sh_mmcif.c
> +++ b/drivers/mmc/host/sh_mmcif.c
> @@ -745,7 +745,6 @@ static u32 sh_mmcif_set_cmd(struct sh_mmcif_host *host,
>  	case MMC_SET_WRITE_PROT:
>  	case MMC_CLR_WRITE_PROT:
>  	case MMC_ERASE:
> -	case MMC_GEN_CMD:
>  		tmp |= CMD_SET_RBSY;
>  		break;
>  	}
> @@ -828,7 +827,6 @@ static void sh_mmcif_start_cmd(struct sh_mmcif_host *host,
>  	case MMC_SET_WRITE_PROT:
>  	case MMC_CLR_WRITE_PROT:
>  	case MMC_ERASE:
> -	case MMC_GEN_CMD:
>  		mask = MASK_START_CMD | MASK_MRBSYE;
>  		break;
>  	default:

Thanks, pushed to mmc-next for 3.4.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-03-09  4:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-07  8:37 [PATCH RESEND] mmc: sh_mmcif: fix MMC_GEN_CMD setting Shimoda, Yoshihiro
2012-03-09  4:47 ` Chris Ball

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).