From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Wed, 07 Mar 2012 18:29:14 +0000 Subject: Re: [PATCH 1/3] Kbuild: centralize MKIMAGE and cmd_uimage definitions Message-Id: <4F57A8FA.8080208@wwwdotorg.org> List-Id: References: <1331080238-1524-1-git-send-email-swarren@wwwdotorg.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Josh Boyer Cc: Michal Marek , linux-arch@vger.kernel.org, Michal Simek , Guan Xuetao , Mike Frysinger , nico@fluxnic.net, linux-sh@vger.kernel.org, microblaze-uclinux@itee.uq.edu.au, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mundt , uclinux-dist-devel@blackfin.uclinux.org, sparclinux@vger.kernel.org, Russell King , Haavard Skinnemoen , "David S. Miller" , linux-arm-kernel@lists.infradead.org, Hans-Christian Egtvedt On 03/07/2012 07:15 AM, Josh Boyer wrote: > On Tue, Mar 6, 2012 at 7:30 PM, Stephen Warren wrote: >> All ARCHs have the same definition of MKIMAGE. Move it to Makefile.lib >> to avoid duplication. >> >> All ARCHs have similar definitions of cmd_uimage. Place a sufficiently >> parameterized version in Makefile.lib to avoid duplication. >> >> The centralized cmd_uimage definition will allow the future introduction >> of a centralized Kconfig option to make cmd_uimage use -T kernel_noload >> rather than -T kernel. ... > Is there a reason you skipped powerpc? grepping the powerpc makefiles showed no hits on MKIMAGE, mkimage or cmd_uimage. Looking a little harder now, this is all inside the shell script arch/powerpc/boot/wrapper. I'm not really sure quite how to unify that shell script with the makefile use of mkimage. Do you have any ideas?