From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Thu, 22 Mar 2012 18:40:38 +0000 Subject: Re: [PATCH] Kbuild: centralize MKIMAGE and cmd_uimage definitions Message-Id: <4F6B7226.8000102@wwwdotorg.org> List-Id: References: <1331931835-12346-1-git-send-email-swarren@wwwdotorg.org> In-Reply-To: <1331931835-12346-1-git-send-email-swarren@wwwdotorg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Marek Cc: Russell King , nico@fluxnic.net, Haavard Skinnemoen , Hans-Christian Egtvedt , Mike Frysinger , Michal Simek , Paul Mundt , "David S. Miller" , Guan Xuetao , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-arm-kernel@lists.infradead.org, uclinux-dist-devel@blackfin.uclinux.org, microblaze-uclinux@itee.uq.edu.au, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org On 03/16/2012 03:03 PM, Stephen Warren wrote: > All ARCHs have the same definition of MKIMAGE. Move it to Makefile.lib > to avoid duplication. > > All ARCHs have similar definitions of cmd_uimage. Place a sufficiently > parameterized version in Makefile.lib to avoid duplication. Michal, Does this change look reasonable? It has acks from people working on 4 of the 7 affected architectures; would you prefer acks from all? Thanks.