From: "Shimoda, Yoshihiro" <yoshihiro.shimoda.uh@renesas.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] usb: r8a66597-udc: add support for set_selfpowered
Date: Wed, 11 Apr 2012 09:51:06 +0000 [thread overview]
Message-ID: <4F85540A.2000602@renesas.com> (raw)
In-Reply-To: <4F62BD24.2060607@renesas.com>
2012/04/11 18:35, Felipe Balbi wrote:
> On Fri, Mar 16, 2012 at 01:10:12PM +0900, Shimoda, Yoshihiro wrote:
>> The previous code always set to USB_DEVICE_SELF_POWERED in GET_STATUS.
>> So, this patch adds set_selfpowered().
>>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> ---
>> drivers/usb/gadget/r8a66597-udc.c | 16 +++++++++++++++-
>> drivers/usb/gadget/r8a66597-udc.h | 1 +
>> 2 files changed, 16 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/r8a66597-udc.c b/drivers/usb/gadget/r8a66597-udc.c
>> index c4401e7..683b3d2 100644
>> --- a/drivers/usb/gadget/r8a66597-udc.c
>> +++ b/drivers/usb/gadget/r8a66597-udc.c
>> @@ -1170,7 +1170,7 @@ __acquires(r8a66597->lock)
>>
>> switch (ctrl->bRequestType & USB_RECIP_MASK) {
>> case USB_RECIP_DEVICE:
>> - status = 1 << USB_DEVICE_SELF_POWERED;
>> + status = r8a66597->device_status;
>> break;
>> case USB_RECIP_INTERFACE:
>> status = 0;
>> @@ -1800,11 +1800,25 @@ static int r8a66597_pullup(struct usb_gadget *gadget, int is_on)
>> return 0;
>> }
>>
>> +static int r8a66597_set_selfpowered(struct usb_gadget *gadget, int is_self)
>> +{
>> + struct r8a66597 *r8a66597 = gadget_to_r8a66597(gadget);
>> + unsigned long flags;
>
> compile warning here. Did you even test this patch ???
I'm sorry, I should have checked it carefully.
I will fix and submit soon.
Best regards,
Yoshihiro Shimoda
prev parent reply other threads:[~2012-04-11 9:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 4:10 [PATCH] usb: r8a66597-udc: add support for set_selfpowered Shimoda, Yoshihiro
2012-04-11 9:35 ` Felipe Balbi
2012-04-11 9:51 ` Shimoda, Yoshihiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F85540A.2000602@renesas.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).