From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Henderson Date: Thu, 01 Jun 2017 20:12:15 +0000 Subject: Re: [PATCH] tty: add TIOCGPTPEER ioctl Message-Id: <4e16e83b-8fb7-c9b6-2f06-ee48499a67db@twiddle.net> List-Id: References: <20170601173803.8698-1-asarai@suse.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Aleksa Sarai , Geert Uytterhoeven Cc: Greg Kroah-Hartman , Jiri Slaby , Arnd Bergmann , "linux-kernel@vger.kernel.org" , alpha , Linux MIPS Mailing List , Parisc List , "linuxppc-dev@lists.ozlabs.org" , Linux-sh list , sparclinux , "linux-xtensa@linux-xtensa.org" , Linux-Arch , Christian Brauner , Valentin Rothberg On 06/01/2017 01:00 PM, Aleksa Sarai wrote: >>> --- a/arch/alpha/include/uapi/asm/ioctls.h >>> +++ b/arch/alpha/include/uapi/asm/ioctls.h >>> @@ -94,6 +94,7 @@ >>> #define TIOCSRS485 _IOWR('T', 0x2F, struct serial_rs485) >>> #define TIOCGPTN _IOR('T',0x30, unsigned int) /* Get Pty Number (of >>> pty-mux device) */ >>> #define TIOCSPTLCK _IOW('T',0x31, int) /* Lock/unlock Pty */ >>> +#define TIOCGPTPEER _IOR('T', 0x41, int) /* Safely open the slave */ >> >> Shouldn't the list of definitions be kept sorted, by hex number? >> (everywhere) > > Probably. The reason I put it here is because it logically is very similar to > TIOCGPTN and TIOSPTLCK, but I can move it if the hex order is more important > for maintainence. > Yes please. r~