From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>,
ysato@users.sourceforge.jp, dalias@libc.org,
laurent.pinchart@ideasonboard.com, hans.verkuil@cisco.com
Cc: linux-sh@vger.kernel.org, linux-media@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] media: arch: sh: migor: Fix TW9910 PDN gpio
Date: Wed, 30 May 2018 11:08:28 +0000 [thread overview]
Message-ID: <4e636f8b-ba38-754a-4763-022eab578934@cogentembedded.com> (raw)
In-Reply-To: <1527671604-18768-1-git-send-email-jacopo+renesas@jmondi.org>
Hello!
On 05/30/2018 12:13 PM, Jacopo Mondi wrote:
> The TW9910 PDN gpio (power down) is listed as active high in the chip
GPIO.
> manual. It turns out it is actually active low as when set to physical
> level 0 it actually turns the video decoder power off.
>
> Without this patch applied:
> tw9910 0-0045: Product ID error 1f:2
>
> With this patch applied:
> tw9910 0-0045: tw9910 Product ID b:0
>
> Fixes: commit "186c446f4b840bd77b79d3dc951ca436cb8abe79"
That's not how you specify the "Fixes:" tag, please see
Documentation/process/submitting-patches.rst.
>
There shouldn't be an emoty line here.
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
[...]
MBR, Sergei
prev parent reply other threads:[~2018-05-30 11:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 9:13 [PATCH] media: arch: sh: migor: Fix TW9910 PDN gpio Jacopo Mondi
2018-05-30 9:30 ` Geert Uytterhoeven
2018-05-30 11:52 ` Laurent Pinchart
2018-05-30 12:23 ` jacopo mondi
2018-05-30 12:38 ` Laurent Pinchart
2018-05-30 12:51 ` jacopo mondi
2018-05-30 11:08 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e636f8b-ba38-754a-4763-022eab578934@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=dalias@libc.org \
--cc=hans.verkuil@cisco.com \
--cc=jacopo+renesas@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox