From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wen Congyang Date: Thu, 06 Sep 2012 08:41:57 +0000 Subject: Re: [RFC v9 PATCH 20/21] memory-hotplug: clear hwpoisoned flag when onlining pages Message-Id: <504861D5.201@cn.fujitsu.com> List-Id: References: <1346837155-534-1-git-send-email-wency@cn.fujitsu.com> <1346837155-534-21-git-send-email-wency@cn.fujitsu.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: =?UTF-8?B?YW5keXd1MTA25bu65Zu9?= Cc: x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, sparclinux@vger.kernel.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, akpm@linux-foundation.org, kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com At 09/06/2012 03:27 PM, andywu106建国 Wrote: > 2012/9/5 >> >> From: Wen Congyang >> >> hwpoisoned may set when we offline a page by the sysfs interface >> /sys/devices/system/memory/soft_offline_page or >> /sys/devices/system/memory/hard_offline_page. If we don't clear >> this flag when onlining pages, this page can't be freed, and will >> not in free list. So we can't offline these pages again. So we >> should clear this flag when onlining pages. >> >> CC: David Rientjes >> CC: Jiang Liu >> CC: Len Brown >> CC: Benjamin Herrenschmidt >> CC: Paul Mackerras >> CC: Christoph Lameter >> Cc: Minchan Kim >> CC: Andrew Morton >> CC: KOSAKI Motohiro >> CC: Yasuaki Ishimatsu >> Signed-off-by: Wen Congyang >> --- >> mm/memory_hotplug.c | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >> index 270c249..140c080 100644 >> --- a/mm/memory_hotplug.c >> +++ b/mm/memory_hotplug.c >> @@ -661,6 +661,11 @@ EXPORT_SYMBOL_GPL(__online_page_increment_counters); >> >> void __online_page_free(struct page *page) >> { >> +#ifdef CONFIG_MEMORY_FAILURE >> + /* The page may be marked HWPoisoned by soft/hard offline page */ >> + ClearPageHWPoison(page); > > Hi Congyang, > I think you should decrease mce_bad_pages counter her > atomic_long_sub(1, &mce_bad_pages); Yes, thanks for pointing it out. Thanks Wen Congyang > >> >> +#endif >> + >> ClearPageReserved(page); >> init_page_count(page); >> __free_page(page); >> -- >> 1.7.1 >> >> -- >> To unsubscribe, send a message with 'unsubscribe linux-mm' in >> the body to majordomo@kvack.org. For more info on Linux MM, >> see: http://www.linux-mm.org/ . >> Don't email: email@kvack.org >