From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 05/11] ARM: shmobile: r8a7778: add MSTP clock assignments to DT
Date: Wed, 21 Jan 2015 23:41:12 +0000 [thread overview]
Message-ID: <5062190.nA0z01PVo3@avalon> (raw)
In-Reply-To: <1371106861-25626-6-git-send-email-horms+renesas@verge.net.au>
Hi Ulrich,
Thank you for the patch.
On Wednesday 21 January 2015 17:20:56 Ulrich Hecht wrote:
> Assigns clocks to i2c*, tmu*, scif*, mmcif, sdhi*, and hspi*.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
> arch/arm/boot/dts/r8a7778.dtsi | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7778.dtsi b/arch/arm/boot/dts/r8a7778.dtsi
> index 0a5c5ad..37c5efb 100644
> --- a/arch/arm/boot/dts/r8a7778.dtsi
> +++ b/arch/arm/boot/dts/r8a7778.dtsi
> @@ -133,6 +133,7 @@
> compatible = "renesas,i2c-r8a7778";
> reg = <0xffc70000 0x1000>;
> interrupts = <0 67 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp0_clks R8A7778_CLK_I2C0>;
> status = "disabled";
> };
>
> @@ -142,6 +143,7 @@
> compatible = "renesas,i2c-r8a7778";
> reg = <0xffc71000 0x1000>;
> interrupts = <0 78 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp0_clks R8A7778_CLK_I2C1>;
> status = "disabled";
> };
>
> @@ -151,6 +153,7 @@
> compatible = "renesas,i2c-r8a7778";
> reg = <0xffc72000 0x1000>;
> interrupts = <0 76 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp0_clks R8A7778_CLK_I2C2>;
> status = "disabled";
> };
>
> @@ -160,6 +163,7 @@
> compatible = "renesas,i2c-r8a7778";
> reg = <0xffc73000 0x1000>;
> interrupts = <0 77 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp0_clks R8A7778_CLK_I2C3>;
> status = "disabled";
> };
>
> @@ -169,6 +173,8 @@
> interrupts = <0 32 IRQ_TYPE_LEVEL_HIGH>,
> <0 33 IRQ_TYPE_LEVEL_HIGH>,
> <0 34 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp0_clks R8A7778_CLK_TMU0>;
> + clock-names = "fck";
>
> #renesas,channels = <3>;
>
> @@ -181,6 +187,7 @@
> interrupts = <0 36 IRQ_TYPE_LEVEL_HIGH>,
> <0 37 IRQ_TYPE_LEVEL_HIGH>,
> <0 38 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp0_clks R8A7778_CLK_TMU1>;
You should add clock-names = "fck"; here.
> #renesas,channels = <3>;
>
> @@ -193,6 +200,7 @@
> interrupts = <0 40 IRQ_TYPE_LEVEL_HIGH>,
> <0 41 IRQ_TYPE_LEVEL_HIGH>,
> <0 42 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp0_clks R8A7778_CLK_TMU2>;
And here too.
> #renesas,channels = <3>;
>
> @@ -203,6 +211,8 @@
> compatible = "renesas,scif-r8a7778", "renesas,scif";
> reg = <0xffe40000 0x100>;
> interrupts = <0 70 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp0_clks R8A7778_CLK_SCIF0>;
> + clock-names = "sci_ick";
> status = "disabled";
> };
>
> @@ -210,6 +220,8 @@
> compatible = "renesas,scif-r8a7778", "renesas,scif";
> reg = <0xffe41000 0x100>;
> interrupts = <0 71 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp0_clks R8A7778_CLK_SCIF1>;
> + clock-names = "sci_ick";
> status = "disabled";
> };
>
> @@ -217,6 +229,8 @@
> compatible = "renesas,scif-r8a7778", "renesas,scif";
> reg = <0xffe42000 0x100>;
> interrupts = <0 72 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp0_clks R8A7778_CLK_SCIF2>;
> + clock-names = "sci_ick";
> status = "disabled";
> };
>
> @@ -224,6 +238,8 @@
> compatible = "renesas,scif-r8a7778", "renesas,scif";
> reg = <0xffe43000 0x100>;
> interrupts = <0 73 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp0_clks R8A7778_CLK_SCIF3>;
> + clock-names = "sci_ick";
> status = "disabled";
> };
>
> @@ -231,6 +247,8 @@
> compatible = "renesas,scif-r8a7778", "renesas,scif";
> reg = <0xffe44000 0x100>;
> interrupts = <0 74 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp0_clks R8A7778_CLK_SCIF4>;
> + clock-names = "sci_ick";
> status = "disabled";
> };
>
> @@ -238,6 +256,8 @@
> compatible = "renesas,scif-r8a7778", "renesas,scif";
> reg = <0xffe45000 0x100>;
> interrupts = <0 75 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp0_clks R8A7778_CLK_SCIF5>;
> + clock-names = "sci_ick";
> status = "disabled";
> };
>
> @@ -245,6 +265,7 @@
> compatible = "renesas,sh-mmcif";
> reg = <0xffe4e000 0x100>;
> interrupts = <0 61 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp3_clks R8A7778_CLK_MMC>;
> status = "disabled";
> };
>
> @@ -252,6 +273,7 @@
> compatible = "renesas,sdhi-r8a7778";
> reg = <0xffe4c000 0x100>;
> interrupts = <0 87 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp3_clks R8A7778_CLK_SDHI0>;
> status = "disabled";
> };
>
> @@ -259,6 +281,7 @@
> compatible = "renesas,sdhi-r8a7778";
> reg = <0xffe4d000 0x100>;
> interrupts = <0 88 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp3_clks R8A7778_CLK_SDHI1>;
> status = "disabled";
> };
>
> @@ -266,6 +289,7 @@
> compatible = "renesas,sdhi-r8a7778";
> reg = <0xffe4f000 0x100>;
> interrupts = <0 86 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp3_clks R8A7778_CLK_SDHI2>;
> status = "disabled";
> };
>
> @@ -273,6 +297,7 @@
> compatible = "renesas,hspi-r8a7778", "renesas,hspi";
> reg = <0xfffc7000 0x18>;
> interrupts = <0 63 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp3_clks R8A7778_CLK_HSPI>;
HSPI is an mstp0 clock.
> #address-cells = <1>;
> #size-cells = <0>;
> status = "disabled";
> @@ -282,6 +307,7 @@
> compatible = "renesas,hspi-r8a7778", "renesas,hspi";
> reg = <0xfffc8000 0x18>;
> interrupts = <0 84 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp3_clks R8A7778_CLK_HSPI>;
Same here.
> #address-cells = <1>;
> #size-cells = <0>;
> status = "disabled";
> @@ -291,6 +317,7 @@
> compatible = "renesas,hspi-r8a7778", "renesas,hspi";
> reg = <0xfffc6000 0x18>;
> interrupts = <0 85 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp3_clks R8A7778_CLK_HSPI>;
And here.
> #address-cells = <1>;
> #size-cells = <0>;
> status = "disabled";
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2015-01-21 23:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 7:00 [PATCH 00/11] Renesas ARM-based SoC updates for v3.11 #2 Simon Horman
2013-06-13 7:00 ` [PATCH 01/11] ARM: shmobile: r8a7779: fix Ether device name Simon Horman
2013-06-13 7:00 ` [PATCH 02/11] ARM: shmobile: r8a7778: " Simon Horman
2013-06-13 7:00 ` [PATCH 03/11] ARM: shmobile: r8a7790: HSCIF support Simon Horman
2013-06-13 7:00 ` [PATCH 04/11] ARM: shmobile: r8a7778: add support I2C clock Simon Horman
2013-06-13 7:00 ` [PATCH 05/11] ARM: shmobile: r8a7778: add support HSPI clock Simon Horman
2015-01-21 16:20 ` [PATCH 05/11] ARM: shmobile: r8a7778: add MSTP clock assignments to DT Ulrich Hecht
2015-01-21 23:41 ` Laurent Pinchart [this message]
2013-06-13 7:00 ` [PATCH 06/11] ARM: shmobile: r8a7778: add support MMC clock Simon Horman
2013-06-13 7:00 ` [PATCH 07/11] ARM: shmobile: r8a7778: add support I2C driver Simon Horman
2013-06-13 7:00 ` [PATCH 08/11] ARM: shmobile: r8a7778: add support HSPI driver Simon Horman
2013-06-13 7:00 ` [PATCH 09/11] ARM: shmobile: r8a7778: add support MMC driver Simon Horman
2013-06-13 7:01 ` [PATCH 10/11] ARM: shmobile: r8a73a4: add clock definitions and aliases for MMCIF and SDHI Simon Horman
2013-06-13 7:01 ` [PATCH 11/11] ARM: shmobile: r8a7790: " Simon Horman
2013-06-15 1:01 ` [PATCH 00/11] Renesas ARM-based SoC updates for v3.11 #2 Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5062190.nA0z01PVo3@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).