From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tang Chen Date: Tue, 04 Dec 2012 09:47:00 +0000 Subject: Re: [Patch v4 08/12] memory-hotplug: remove memmap of sparse-vmemmap Message-Id: <50BDC694.1060509@cn.fujitsu.com> List-Id: References: <1354010422-19648-1-git-send-email-wency@cn.fujitsu.com> <1354010422-19648-9-git-send-email-wency@cn.fujitsu.com> In-Reply-To: <1354010422-19648-9-git-send-email-wency@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wen Congyang Cc: x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, sparclinux@vger.kernel.org, David Rientjes , Jiang Liu , Len Brown , benh@kernel.crashing.org, paulus@samba.org, Christoph Lameter , Minchan Kim , Andrew Morton , KOSAKI Motohiro , Yasuaki Ishimatsu , Jianguo Wu On 11/27/2012 06:00 PM, Wen Congyang wrote: > static int __remove_section(struct zone *zone, struct mem_section *ms) > { > unsigned long flags; > @@ -330,9 +317,9 @@ static int __remove_section(struct zone *zone, struct mem_section *ms) > pgdat_resize_lock(pgdat,&flags); > sparse_remove_one_section(zone, ms); > pgdat_resize_unlock(pgdat,&flags); > - return 0; > + > + return ret; I think we don't need to change this line. :) Reviewed-by: Tang Chen