From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tang Chen Date: Thu, 27 Dec 2012 03:09:35 +0000 Subject: Re: [PATCH v5 04/14] memory-hotplug: remove /sys/firmware/memmap/X sysfs Message-Id: <50DBBBEF.70701@cn.fujitsu.com> List-Id: References: <1356350964-13437-1-git-send-email-tangchen@cn.fujitsu.com> <1356350964-13437-5-git-send-email-tangchen@cn.fujitsu.com> <50DA6F5A.2070601@jp.fujitsu.com> In-Reply-To: <50DA6F5A.2070601@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kamezawa Hiroyuki Cc: akpm@linux-foundation.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, wujianguo@huawei.com, wency@cn.fujitsu.com, hpa@zytor.com, linfeng@cn.fujitsu.com, laijs@cn.fujitsu.com, mgorman@suse.de, yinghai@kernel.org, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, sparclinux@vger.kernel.org On 12/26/2012 11:30 AM, Kamezawa Hiroyuki wrote: >> @@ -41,6 +42,7 @@ struct firmware_map_entry { >> const char *type; /* type of the memory range */ >> struct list_head list; /* entry for the linked list */ >> struct kobject kobj; /* kobject for each entry */ >> + unsigned int bootmem:1; /* allocated from bootmem */ >> }; > > Can't we detect from which the object is allocated from, slab or bootmem ? > > Hm, for example, > > PageReserved(virt_to_page(address_of_obj)) ? > PageSlab(virt_to_page(address_of_obj)) ? > Hi Kamezawa-san, I think we can detect it without a new member. I think bootmem:1 member is just for convenience. I think I can remove it. :) Thanks. :)