Re: [PATCH v2] shmobile: ipmmu: Add basic PMB support

[Damian Hobson-Garcia <dhobsong@igel.co.jp>]

Morimoto-san,

On 2013/02/08 10:59, Kuninori Morimoto wrote:
>
> Hi Damian
>
> one comment from me
>
>> +void *ipmmu_pmb_init(struct shmobile_ipmmu *ipmmu)
>> +{
>> +	int err = -ENOENT;
>> +	int i;
>> +	struct ipmmu_pmb_priv *priv;
>> +
>> +	priv = devm_kzalloc(ipmmu->dev, sizeof(struct ipmmu_pmb_priv),
>> +								GFP_KERNEL);
>> +	if (!priv) {
>> +		dev_err(ipmmu->dev, "cannot allocate device data\n");
>> +		return ERR_PTR(-ENOMEM);
>> +	}
> (snip)
>> +destroy_device:
>> +	device_destroy(priv->pmb_class, priv->pmb_dev);
>> +unregister_region:
>> +	unregister_chrdev_region(priv->pmb_dev, 1);
>> +destroy_class:
>> +	class_destroy(priv->pmb_class);
>> +free_priv:
>> +	kfree(priv);
>> +	return ERR_PTR(err);
>> +}
>
> you are using devm_kzalloc() for priv.
> This means kfree(priv) is not needed here.
Oops.  Thank you.  I removed the kfree from the deinit, but forgot about 
it here.

Damian
>
> Best regards
> ---
> Kuninori Morimoto
>


-- 
Damian Hobson-Garcia
IGEL Co.,Ltd
http://www.igel.co.jp